Closed Bug 1152022 Opened 6 years ago Closed 6 years ago

Tracking: ensure github version of Readability/JSDOMParser make it into mozilla-central and aurora/beta every week

Categories

(Toolkit :: Reader Mode, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
firefox38 --- fixed
firefox39 --- fixed
firefox40 --- affected

People

(Reporter: Gijs, Assigned: Gijs)

References

Details

(Keywords: meta)

Attachments

(1 file)

The plan is to track the landings onto m-c and the respective uplifts in here. We'll try to land on (integration to) m-c (at least) every Friday, and thereby make the beta uplift in time for the beta go-to-build on Monday.
Has this been uplifted at all? I want to uplift bug 1150695, but that will depend on some pretty recent changes being uplifted.
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to :Margaret Leibovic from comment #1)
> Has this been uplifted at all? I want to uplift bug 1150695, but that will
> depend on some pretty recent changes being uplifted.

Nope, this is here as a reminder to myself that I need to do it every Friday, and as a place for the patches + approval requests + landing tracking to go.
Flags: needinfo?(gijskruitbosch+bugs)
Depends on: 1153262
Comment on attachment 8590945 [details] [diff] [review]
Update Readability to github tip dd. April 10

Approval Request Comment
[Feature/regressing bug #]: Reader Mode
[User impact if declined]: this blocks several fixes on the Firefox side as well as readability output improvements on e.g. heise.de (bug 1152817)
[Describe test coverage new/current, TreeHerder]: this has github-based tests and in-tree tests. This will need bug 1153262 to also be uplifted (uplifts requests there to follow shortly) in order to avoid a spurious android test failure
[Risks and why]: low, the change is localized to readability output/handling, and we're confident this is an improvement there.
[String/UUID change made/needed]: nope
Attachment #8590945 - Attachment description: , update Readability to github tip, → Update Readability to github tip dd. April 10
Attachment #8590945 - Flags: approval-mozilla-beta?
Attachment #8590945 - Flags: approval-mozilla-aurora?
Comment on attachment 8590945 [details] [diff] [review]
Update Readability to github tip dd. April 10

Should be in 38 beta 4.
Please update a new bug for the next update. otherwise, sheriff might not see the uplift
Attachment #8590945 - Flags: approval-mozilla-beta?
Attachment #8590945 - Flags: approval-mozilla-beta+
Attachment #8590945 - Flags: approval-mozilla-aurora?
Attachment #8590945 - Flags: approval-mozilla-aurora+
Comment on attachment 8590945 [details] [diff] [review]
Update Readability to github tip dd. April 10

oups, not yet in mc
Attachment #8590945 - Flags: approval-mozilla-beta?
Attachment #8590945 - Flags: approval-mozilla-beta+
Attachment #8590945 - Flags: approval-mozilla-aurora?
Attachment #8590945 - Flags: approval-mozilla-aurora+
Attachment #8590945 - Flags: approval-mozilla-beta?
Attachment #8590945 - Flags: approval-mozilla-beta+
Attachment #8590945 - Flags: approval-mozilla-aurora?
Attachment #8590945 - Flags: approval-mozilla-aurora+
I had to fold in a previous "No bug" update to get this to uplift to Aurora/Beta. Can we please have proper bugs tracking these updates rather than having a bunch of "No bug" commits that make tracking a royal PITA? Unless your team wants to handle uplifts for this feature anyway.
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #9)
> I had to fold in a previous "No bug" update to get this to uplift to
> Aurora/Beta. Can we please have proper bugs tracking these updates rather
> than having a bunch of "No bug" commits that make tracking a royal PITA?
> Unless your team wants to handle uplifts for this feature anyway.

I was planning to only do uplifts referencing this bug number and logging those here, making it easy to create actual patches that we can assess for risk etc. I'm also happy to do uplifts myself; sorry the initial landings here were bumpy. I'm hoping this weeks' (land on fx-team friday, uplift next week on Monday) will be better.
Flags: needinfo?(gijskruitbosch+bugs)
My only problem with that plan is that it'll make tracking those uplifts next to impossible, since the status will never be "fixed" if you're using one bug to track ongoing uplifts. Speaking of which...
Setting back to fixed per discussion w/ Gijs on IRC.
Depends on: 1155692
Depends on: 1158184
Depends on: 1158228
Depends on: 1162917
(no merges in the github repo since the last uplift, so no uplifts today / this weekend / monday)
We're done here.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in before you can comment on or make changes to this bug.