1152022 - Tracking: ensure github version of Readability/JSDOMParser make it into mozilla-central and aurora/beta every week

Status: RESOLVED FIXED

(Toolkit :: Reader Mode, defect)

Description

[:Gijs (he/him)]

The plan is to track the landings onto m-c and the respective uplifts in here. We'll try to land on (integration to) m-c (at least) every Friday, and thereby make the beta uplift in time for the beta go-to-build on Monday.

Comment 1

[:Margaret Leibovic]

Has this been uplifted at all? I want to uplift bug 1150695, but that will depend on some pretty recent changes being uplifted.

Comment 2

[:Gijs (he/him)]

(In reply to :Margaret Leibovic from comment #1)
> Has this been uplifted at all? I want to uplift bug 1150695, but that will
> depend on some pretty recent changes being uplifted.

Nope, this is here as a reminder to myself that I need to do it every Friday, and as a place for the patches + approval requests + landing tracking to go.

Comment 3

[:Gijs (he/him)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/481d6df1fdca

Comment 4

[:Gijs (he/him)]

Attachment: Update Readability to github tip dd. April 10

Comment 5

[:Gijs (he/him)]

Comment on attachment 8590945 [details] [diff] [review]
Update Readability to github tip dd. April 10

Approval Request Comment
[Feature/regressing bug #]: Reader Mode
[User impact if declined]: this blocks several fixes on the Firefox side as well as readability output improvements on e.g. heise.de (bug 1152817)
[Describe test coverage new/current, TreeHerder]: this has github-based tests and in-tree tests. This will need bug 1153262 to also be uplifted (uplifts requests there to follow shortly) in order to avoid a spurious android test failure
[Risks and why]: low, the change is localized to readability output/handling, and we're confident this is an improvement there.
[String/UUID change made/needed]: nope

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8590945 [details] [diff] [review]
Update Readability to github tip dd. April 10

Should be in 38 beta 4.
Please update a new bug for the next update. otherwise, sheriff might not see the uplift

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8590945 [details] [diff] [review]
Update Readability to github tip dd. April 10

oups, not yet in mc

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/481d6df1fdca

Comment 9

[Ryan VanderMeulen [:RyanVM]]

I had to fold in a previous "No bug" update to get this to uplift to Aurora/Beta. Can we please have proper bugs tracking these updates rather than having a bunch of "No bug" commits that make tracking a royal PITA? Unless your team wants to handle uplifts for this feature anyway.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8a12cc844b1c

Comment 11

[:Gijs (he/him)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #9)
> I had to fold in a previous "No bug" update to get this to uplift to
> Aurora/Beta. Can we please have proper bugs tracking these updates rather
> than having a bunch of "No bug" commits that make tracking a royal PITA?
> Unless your team wants to handle uplifts for this feature anyway.

I was planning to only do uplifts referencing this bug number and logging those here, making it easy to create actual patches that we can assess for risk etc. I'm also happy to do uplifts myself; sorry the initial landings here were bumpy. I'm hoping this weeks' (land on fx-team friday, uplift next week on Monday) will be better.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

My only problem with that plan is that it'll make tracking those uplifts next to impossible, since the status will never be "fixed" if you're using one bug to track ongoing uplifts. Speaking of which...

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Setting back to fixed per discussion w/ Gijs on IRC.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/333017ad43a9

Comment 15

[:Gijs (he/him)]

(no merges in the github repo since the last uplift, so no uplifts today / this weekend / monday)

Comment 16

[:Gijs (he/him)]

We're done here.

Comment 17

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.