Closed Bug 1152041 Opened 5 years ago Closed 5 years ago

Don't open autodial dialogs after shutdown.

Categories

(Core :: Networking, defect)

All
Windows
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox39 + wontfix
firefox40 + fixed
firefox41 + fixed

People

(Reporter: mayhemer, Assigned: dragana)

References

Details

Attachments

(1 file)

We get shutdown deadlock.

https://crash-stats.mozilla.com/report/index/5ba8f826-a4b2-4131-a63c-e4b112150404#allthreads, thread 11 (socket thread) shows a dialog via nsAutodial::DialDefault:

RasDialDlgW
nsAutodial::DialDefault(wchar_t const*)
nsNativeConnectionHelper::OnConnectionFailed(wchar_t const*)
nsSocketTransport::RecoverFromError()
mozilla::net::nsHttpConnectionMgr::nsHalfOpenSocket::OnTransportStatus(nsITransport*, nsresult, __int64, __int64)
Blocks: 1158189
No longer blocks: 1124880
Assignee: nobody → dd.mozilla
Status: NEW → ASSIGNED
Attachment #8603740 - Flags: review?(honzab.moz)
Comment on attachment 8603740 [details] [diff] [review]
bug_1152041_v1.patch

Review of attachment 8603740 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.  Let's see how it works.
Attachment #8603740 - Flags: review?(honzab.moz) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/69fcbc1da823
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Should this be uplifted to aurora and maybe beta? It is late for beta but if it doesn't seem too risky, we are hoping to get the crash rate down.
Flags: needinfo?(honzab.moz)
Probably, Dragana, can you request approvals?
Flags: needinfo?(honzab.moz) → needinfo?(dd.mozilla)
[Tracking Requested - why for this release]:

Too late for beta.  This could still make it into 40.
I would like to uplift bug 1169554 as well. It is not an error in this bug just makes it more restrictive and I feel better about it.
Flags: needinfo?(dd.mozilla)
Comment on attachment 8603740 [details] [diff] [review]
bug_1152041_v1.patch

Approval Request Comment
[Feature/regressing bug #]: long existing bug
[User impact if declined]: it is a crash
[Describe test coverage new/current, TreeHerder]: it is in Nightly for some weeks
[Risks and why]: low risk a simple patch and it is in Nightly for some weeks
[String/UUID change made/needed]: none
Attachment #8603740 - Flags: approval-mozilla-aurora?
Depends on: 1169554
Comment on attachment 8603740 [details] [diff] [review]
bug_1152041_v1.patch

fix a crash, taking it.
Attachment #8603740 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.