1152041 - Don't open autodial dialogs after shutdown.

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Honza Bambas (:mayhemer)]

We get shutdown deadlock.

https://crash-stats.mozilla.com/report/index/5ba8f826-a4b2-4131-a63c-e4b112150404#allthreads, thread 11 (socket thread) shows a dialog via nsAutodial::DialDefault:

RasDialDlgW
nsAutodial::DialDefault(wchar_t const*)
nsNativeConnectionHelper::OnConnectionFailed(wchar_t const*)
nsSocketTransport::RecoverFromError()
mozilla::net::nsHttpConnectionMgr::nsHalfOpenSocket::OnTransportStatus(nsITransport*, nsresult, __int64, __int64)

Comment 1

[Dragana Damjanovic [:dragana]]

Attachment: bug_1152041_v1.patch

Comment 2

[Dragana Damjanovic [:dragana]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=15f4b976c11d

Comment 3

[Honza Bambas (:mayhemer)]

Comment on attachment 8603740 [details] [diff] [review]
bug_1152041_v1.patch

Review of attachment 8603740 [details] [diff] [review]:
-----------------------------------------------------------------

Nice.  Let's see how it works.

Comment 4

[Dragana Damjanovic [:dragana]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=10660220b7c6

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/69fcbc1da823

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/69fcbc1da823

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

Should this be uplifted to aurora and maybe beta? It is late for beta but if it doesn't seem too risky, we are hoping to get the crash rate down.

Comment 8

[Honza Bambas (:mayhemer)]

Probably, Dragana, can you request approvals?

Comment 9

[Liz Henry (:lizzard) (relman/hg->git project)]

[Tracking Requested - why for this release]:

Too late for beta.  This could still make it into 40.

Comment 10

[Dragana Damjanovic [:dragana]]

I would like to uplift bug 1169554 as well. It is not an error in this bug just makes it more restrictive and I feel better about it.

Comment 11

[Dragana Damjanovic [:dragana]]

Comment on attachment 8603740 [details] [diff] [review]
bug_1152041_v1.patch

Approval Request Comment
[Feature/regressing bug #]: long existing bug
[User impact if declined]: it is a crash
[Describe test coverage new/current, TreeHerder]: it is in Nightly for some weeks
[Risks and why]: low risk a simple patch and it is in Nightly for some weeks
[String/UUID change made/needed]: none

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8603740 [details] [diff] [review]
bug_1152041_v1.patch

fix a crash, taking it.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4ecb3e9c8671