1152122 - unused function '_Android_GetAddrInfoForNetInterface' [-Wunused-function]

Status: RESOLVED DUPLICATE of bug 1152329

(Core :: Networking: DNS, defect)

Description

[Ralph Giles (:rillian)]

This broke my build with --enable-warnings-as-errors today, although there are no local changes, so I couldn't find a dependent bug. Maybe it got enabled for netwerk at a higher level?

Comment 1

[Ralph Giles (:rillian)]

Attachment: Fix unused function warning

#ifdef out the Android-specific function.

Comment 2

[Chris Peterson [:cpeterson]]

Comment on attachment 8589360 [details] [diff] [review]
Fix unused function warning

Review of attachment 8589360 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/dns/GetAddrInfo.cpp
@@ +220,4 @@
>  }
>  #endif
>  
> +#if defined(ANDROID)

The function _Android_GetAddrInfoForNetInterface() is only called #if defined(ANDROID) && ANDROID_VERSION >= 19, so the function definition is only needed #if defined(ANDROID) && ANDROID_VERSION >= 19. Do we ever build with ANDROID_VERSION < 19?

Comment 3

[Patrick McManus [:mcmanus]]

Comment on attachment 8589360 [details] [diff] [review]
Fix unused function warning

Review of attachment 8589360 [details] [diff] [review]:
-----------------------------------------------------------------

I believe dragana was involved in this, so I'll delegate the review to her

Comment 5

[Dragana Damjanovic [:dragana]]

Comment on attachment 8589360 [details] [diff] [review]
Fix unused function warning

Review of attachment 8589360 [details] [diff] [review]:
-----------------------------------------------------------------

There is a patch in bug 1152329.

Comment 6

[Daniel Holbert [:dholbert]]

[moving bug-dependencies to dupe-target.]