Closed
Bug 1152122
Opened 10 years ago
Closed 10 years ago
unused function '_Android_GetAddrInfoForNetInterface' [-Wunused-function]
Categories
(Core :: Networking: DNS, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1152329
Tracking | Status | |
---|---|---|
firefox40 | --- | affected |
People
(Reporter: rillian, Assigned: rillian)
Details
Attachments
(1 file)
876 bytes,
patch
|
Details | Diff | Splinter Review |
This broke my build with --enable-warnings-as-errors today, although there are no local changes, so I couldn't find a dependent bug. Maybe it got enabled for netwerk at a higher level?
Assignee | ||
Comment 1•10 years ago
|
||
#ifdef out the Android-specific function.
Assignee: nobody → giles
Attachment #8589360 -
Flags: review?(honzab.moz)
Updated•10 years ago
|
Blocks: 1108957, buildwarning
Comment 2•10 years ago
|
||
Comment on attachment 8589360 [details] [diff] [review]
Fix unused function warning
Review of attachment 8589360 [details] [diff] [review]:
-----------------------------------------------------------------
::: netwerk/dns/GetAddrInfo.cpp
@@ +220,4 @@
> }
> #endif
>
> +#if defined(ANDROID)
The function _Android_GetAddrInfoForNetInterface() is only called #if defined(ANDROID) && ANDROID_VERSION >= 19, so the function definition is only needed #if defined(ANDROID) && ANDROID_VERSION >= 19. Do we ever build with ANDROID_VERSION < 19?
Comment 3•10 years ago
|
||
Comment on attachment 8589360 [details] [diff] [review]
Fix unused function warning
Review of attachment 8589360 [details] [diff] [review]:
-----------------------------------------------------------------
I believe dragana was involved in this, so I'll delegate the review to her
Attachment #8589360 -
Flags: review?(honzab.moz) → review?(dd.mozilla)
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → DUPLICATE
Comment 5•10 years ago
|
||
Comment on attachment 8589360 [details] [diff] [review]
Fix unused function warning
Review of attachment 8589360 [details] [diff] [review]:
-----------------------------------------------------------------
There is a patch in bug 1152329.
Attachment #8589360 -
Flags: review?(dd.mozilla)
Comment 6•10 years ago
|
||
[moving bug-dependencies to dupe-target.]
No longer blocks: buildwarning, 1108957
You need to log in
before you can comment on or make changes to this bug.
Description
•