1152126 - (jpm-addon) Simplify add-on development process by building set of features into firefox & GCLI

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect)

Comment 1

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: jetpack-id is one of the required dependencies

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 8589368 [details] [review]
jetpack-id is one of the required dependencies

There are some files included which don't look necessary, especially if this is going to be a fork of jetpack-id.

Also I believe Jordan mentioned in irc yesterday that he was fine making jetpack-id MPL, so I think we should do that first.

Jordan, are alright with changing this license to MPL 2?

Comment 3

[Jordan Santell [:jsantell] [@jsantell]]

Just updated jetpack-id 1.0.0 and released as MPL 2.0, and commented on PR -- leaving the package.json in there will provide all the meta (don't need tests, etc)

Comment 4

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/87006fabcf03b0dd01e73f4e95415d03b0c4e3de
Merge pull request #1931 from Gozala/jetpack-id

Bug 1152126 - Add jetpack-id package. r=@erikvold

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Import mozilla-toolkit-versioning

Comment 6

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: GCLI wrapper used by jpm add-on

Comment 7

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Implementation of JPM as an add-on.

Comment 9

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8595696 [details] [review]
GCLI wrapper used by jpm add-on

The GCLI wrapper could use some comments on how to use it, but r+

Comment 10

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8595783 [details] [review]
Implementation of JPM as an add-on.

Left a handful of comments -- but generally, the style doesn't really match anything else in the SDK (unless I'm really out of date), with opening curlies on the left-side and aggressive new lines resulting in a very vertical structure that only extends about 30 characters across.

There is only one line of comments (and the other is ported from the rdf implementation from node) -- making this even harder to understand. This needs function descriptions, as I have no idea what most of the functions, let alone modules, are supposed to do unless I dig around tests. Is jpm/core just gcli hooks? There's no mention of that. How do I even use the zip module? Aside from the lack of high-level comments for modules/functions, there's no comments inside of functions either -- this all looks very difficult for anyone else to maintain.

I think the zip utility should live in sdk/ somewhere.

I don't think this should be called `jpm` either -- I think that'll lead to confusion. Seems like it's gcli commands for addons.

How do I use this? require("jpm") and it just binds gcli commands? Where does that occur, in the gcli devtools? Is this only for internal use?

Comment 11

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/0ad61f1ed6d343e0d51dbaa863aaa07024719507
Merge pull request #1939 from Gozala/gcli-wrapper

Bug 1152126 - Implement a wrapper for gcli. r=@jsantell

Comment 12

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/2fc791d2625af651cc0fd08ee606d49b0c522043
Revert "Bug 1152126 - Implement a wrapper for gcli."

https://github.com/mozilla/addon-sdk/commit/2f5fa877b3b0dbb4220ac5af01263ef2cf89f9cd
Merge pull request #1941 from mozilla/revert-1939-gcli-wrapper

Revert "Bug 1152126 - Implement a wrapper for gcli."

Comment 13

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562