Closed Bug 115217 Opened 22 years ago Closed 22 years ago

merging libnkcache.so with libnecko.so improves startup time

Categories

(Core :: Networking: Cache, defect, P2)

Product:
Core
Component:
Networking: Cache
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.2beta

People

(Reporter: darin.moz, Assigned: alecf)

References

Details

(Keywords: embed, perf, Whiteboard: fix in hand)

Attachments

(1 file, 3 obsolete files)

combined patch
57.22 KB, patch
alecf
: review+
alecf
: superreview+
Details | Diff | Splinter Review 
merging nkcache module with necko module improves startup time

on an optimized linux build, i noticed about a 0.8% startup improvement after
merging libnkcache.so with libnecko.so.

there's no real reason to keep the cache in a separate dll.  it was originally
intended to be part of the core necko module, and only started out as a separate
module to simplify development.

    
  
Blocks: 7251
Keywords: perf

    
  
No longer blocks: 7251
Status: NEW → ASSIGNED
Priority: -- → P3
Target Milestone: --- → mozilla0.9.8

    
  
Blocks: 7251

    
    

    
  
Cool. Remember to:
a) Update all platform makefiles
b) Update package list to remove nkcache.dll
c) Send mail to people building dep to remove nkcache.dll from components/ or
just clobber build

Current changes look ok.

    
    

    
  
-> 0.9.9
Target Milestone: mozilla0.9.8 → mozilla0.9.9

    
  
Severity: normal → minor
Priority: P3 → P4

    
  
Target Milestone: mozilla0.9.9 → mozilla1.0

    
    

    
  
-> 1.0

    
    

    
  
Moving Netscape owned 0.9.9 and 1.0 bugs that don't have an nsbeta1, nsbeta1+,
topembed, topembed+, Mozilla0.9.9+ or Mozilla1.0+ keyword.  Please send any
questions or feedback about this to adt@netscape.com.  You can search for
"Moving bugs not scheduled for a project" to quickly delete this bugmail.
Target Milestone: mozilla1.0 → mozilla1.2

    
  
Target Milestone: mozilla1.2alpha → ---

    
    

    
  
mass futuring of untargeted bugs
Target Milestone: --- → Future

    
  
Blocks: 163737

    
    

    
  
-> moz 1.2
Keywords: embed, 
          
            mozilla1.2, 
          
            nsbeta1
Target Milestone: Future → mozilla1.2beta

    
    

    
  
taking this, I'll have a complete fix (With mac support) relatively soon...
Assignee: darin → alecf
Status: ASSIGNED → NEW

    
  
Priority: P4 → P2

    
    

    
  

      
      
      
      

        Attached patch
          
          
        cleaned up patch (obsolete)
        — 
          — Splinter Review
      

    


  
I decided to just start from scratch. I'm keeping nkcache as a seperate
"module" for now, I don't see any harm and it allows us to be more explicit
about our dependencies. 

I'll do the mac project stuff and the packager stuff when either bug 168048 or
bug 169003 gets reviewed & checked in (they are poluting both my trees at the
moment)

        Attachment #61719 -
        Attachment is obsolete: true

    
  

        Attachment #99456 -
        Flags: superreview+

    
    

    
  
Comment on attachment 99456 [details] [diff] [review]
cleaned up patch

r/sr=darin (looks good to me)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        mac project changes (obsolete)
        — 
          — Splinter Review
      

    


  
here are the mac project changes to merge nkcache into necko - the patch looks
more complicated than it is because CW decided to be stupid when it exported
the file.

    
    

    
  
Comment on attachment 99456 [details] [diff] [review]
cleaned up patch

r=dougt

        Attachment #99456 -
        Flags: review+

    
    

    
  
Comment on attachment 99847 [details] [diff] [review]
mac project changes

r=dougt

        Attachment #99847 -
        Flags: review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        combined patch
        — 
          — Splinter Review
      

    


  
on the other hand, I could just combine it all into one patch and include
packaging changes. Reviews? TIA..

        Attachment #99456 -
        Attachment is obsolete: true

        Attachment #99847 -
        Attachment is obsolete: true

    
  
Status: NEW → ASSIGNED
Whiteboard: fix in hand

    
    

    
  
Comment on attachment 99851 [details] [diff] [review]
combined patch

oh, doug already gave his review. Then I'm transferring over sr=darin, r=dougt
if nobody objects..

        Attachment #99851 -
        Flags: superreview+

        Attachment #99851 -
        Flags: review+

    
    

    
  
and now its fixed.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED

    
    

    
  
thanks alec!!

    
    

    
  
verified - confirmed patch checked in
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.