Closed
Bug 115217
Opened 22 years ago
Closed 22 years ago
merging libnkcache.so with libnecko.so improves startup time
Categories
(Core :: Networking: Cache, defect, P2)
Core
Networking: Cache
Tracking
()
VERIFIED
FIXED
mozilla1.2beta
People
(Reporter: darin.moz, Assigned: alecf)
References
Details
(Keywords: embed, perf, Whiteboard: fix in hand)
Attachments
(1 file, 3 obsolete files)
57.22 KB,
patch
|
alecf
:
review+
alecf
:
superreview+
|
Details | Diff | Splinter Review |
merging nkcache module with necko module improves startup time on an optimized linux build, i noticed about a 0.8% startup improvement after merging libnkcache.so with libnecko.so. there's no real reason to keep the cache in a separate dll. it was originally intended to be part of the core necko module, and only started out as a separate module to simplify development.
Reporter | ||
Comment 1•22 years ago
|
||
Updated•22 years ago
|
Reporter | ||
Updated•22 years ago
|
Comment 2•22 years ago
|
||
Cool. Remember to: a) Update all platform makefiles b) Update package list to remove nkcache.dll c) Send mail to people building dep to remove nkcache.dll from components/ or just clobber build Current changes look ok.
Reporter | ||
Updated•22 years ago
|
Severity: normal → minor
Priority: P3 → P4
Reporter | ||
Updated•22 years ago
|
Target Milestone: mozilla0.9.9 → mozilla1.0
Reporter | ||
Comment 4•22 years ago
|
||
-> 1.0
Comment 5•22 years ago
|
||
Moving Netscape owned 0.9.9 and 1.0 bugs that don't have an nsbeta1, nsbeta1+, topembed, topembed+, Mozilla0.9.9+ or Mozilla1.0+ keyword. Please send any questions or feedback about this to adt@netscape.com. You can search for "Moving bugs not scheduled for a project" to quickly delete this bugmail.
Target Milestone: mozilla1.0 → mozilla1.2
Reporter | ||
Updated•22 years ago
|
Target Milestone: mozilla1.2alpha → ---
Assignee | ||
Comment 8•22 years ago
|
||
taking this, I'll have a complete fix (With mac support) relatively soon...
Assignee: darin → alecf
Status: ASSIGNED → NEW
Assignee | ||
Updated•22 years ago
|
Priority: P4 → P2
Assignee | ||
Comment 9•22 years ago
|
||
I decided to just start from scratch. I'm keeping nkcache as a seperate "module" for now, I don't see any harm and it allows us to be more explicit about our dependencies. I'll do the mac project stuff and the packager stuff when either bug 168048 or bug 169003 gets reviewed & checked in (they are poluting both my trees at the moment)
Attachment #61719 -
Attachment is obsolete: true
Reporter | ||
Updated•22 years ago
|
Attachment #99456 -
Flags: superreview+
Reporter | ||
Comment 10•22 years ago
|
||
Comment on attachment 99456 [details] [diff] [review] cleaned up patch r/sr=darin (looks good to me)
Assignee | ||
Comment 11•22 years ago
|
||
here are the mac project changes to merge nkcache into necko - the patch looks more complicated than it is because CW decided to be stupid when it exported the file.
Comment 12•22 years ago
|
||
Comment on attachment 99456 [details] [diff] [review] cleaned up patch r=dougt
Attachment #99456 -
Flags: review+
Comment 13•22 years ago
|
||
Comment on attachment 99847 [details] [diff] [review] mac project changes r=dougt
Attachment #99847 -
Flags: review+
Assignee | ||
Comment 14•22 years ago
|
||
on the other hand, I could just combine it all into one patch and include packaging changes. Reviews? TIA..
Attachment #99456 -
Attachment is obsolete: true
Attachment #99847 -
Attachment is obsolete: true
Assignee | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Whiteboard: fix in hand
Assignee | ||
Comment 15•22 years ago
|
||
Comment on attachment 99851 [details] [diff] [review] combined patch oh, doug already gave his review. Then I'm transferring over sr=darin, r=dougt if nobody objects..
Attachment #99851 -
Flags: superreview+
Attachment #99851 -
Flags: review+
Assignee | ||
Comment 16•22 years ago
|
||
and now its fixed.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 17•22 years ago
|
||
thanks alec!!
You need to log in
before you can comment on or make changes to this bug.
Description
•