115217 - merging libnkcache.so with libnecko.so improves startup time

Status: VERIFIED FIXED

Description

[Darin Fisher]

merging nkcache module with necko module improves startup time

on an optimized linux build, i noticed about a 0.8% startup improvement after
merging libnkcache.so with libnecko.so.

there's no real reason to keep the cache in a separate dll.  it was originally
intended to be part of the core necko module, and only started out as a separate
module to simplify development.

Comment 1

[Darin Fisher]

Attachment: hacked up linux patch... needs to be cleaned up

Comment 2

[Suresh Duddi (gone)]

Cool. Remember to:
a) Update all platform makefiles
b) Update package list to remove nkcache.dll
c) Send mail to people building dep to remove nkcache.dll from components/ or
just clobber build

Current changes look ok.

Comment 3

[Darin Fisher]

-> 0.9.9

Comment 4

[Darin Fisher]

-> 1.0

Comment 5

[scottputterman]

Moving Netscape owned 0.9.9 and 1.0 bugs that don't have an nsbeta1, nsbeta1+,
topembed, topembed+, Mozilla0.9.9+ or Mozilla1.0+ keyword.  Please send any
questions or feedback about this to [e-mail].  You can search for
"Moving bugs not scheduled for a project" to quickly delete this bugmail.

Comment 6

[Darin Fisher]

mass futuring of untargeted bugs

Comment 7

[Darin Fisher]

-> moz 1.2

Comment 8

[Alec Flett]

taking this, I'll have a complete fix (With mac support) relatively soon...

Comment 9

[Alec Flett]

Attachment: cleaned up patch

I decided to just start from scratch. I'm keeping nkcache as a seperate
"module" for now, I don't see any harm and it allows us to be more explicit
about our dependencies. 

I'll do the mac project stuff and the packager stuff when either bug 168048 or
bug 169003 gets reviewed & checked in (they are poluting both my trees at the
moment)

Comment 10

[Darin Fisher]

Comment on attachment 99456 [details] [diff] [review]
cleaned up patch

r/sr=darin (looks good to me)

Comment 11

[Alec Flett]

Attachment: mac project changes

here are the mac project changes to merge nkcache into necko - the patch looks
more complicated than it is because CW decided to be stupid when it exported
the file.

Comment 12

[Doug Turner (:dougt)]

Comment on attachment 99456 [details] [diff] [review]
cleaned up patch

r=dougt

Comment 13

[Doug Turner (:dougt)]

Comment on attachment 99847 [details] [diff] [review]
mac project changes

r=dougt

Comment 14

[Alec Flett]

Attachment: combined patch

on the other hand, I could just combine it all into one patch and include
packaging changes. Reviews? TIA..

Comment 15

[Alec Flett]

Comment on attachment 99851 [details] [diff] [review]
combined patch

oh, doug already gave his review. Then I'm transferring over sr=darin, r=dougt
if nobody objects..

Comment 16

[Alec Flett]

and now its fixed.

Comment 17

[Darin Fisher]

thanks alec!!

Comment 18

[Tom Everingham]

verified - confirmed patch checked in