1152227 - [RTL][Notifications]The name of screenshot is displayed wrongly on notification in test device.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect, P1)

Description

[Lancy(Leave from Mozilla)]

[1.Description]:
[RTL][v2.2&v3.0][Notifications]Enable BTand pair with another device, transfer screenshot from another device and recieve it in test device, the name of screenshot is displayed wrongly on notification in test device.
See attachment:Screenshot_notification.png

[2.Testing Steps]: 
1.Set your phone language to Arabic. 
2.Enable BTand paired with another device.
3.Send a screenshot to test device from another device via BT. 
4.Tap the notification.
5.Accept the transfer. 
6.Complete the transmission and observe the prompt in notifications. 

[3.Expected Result]: 
6.The file format of the screenshot should be displayed at right side of the name.

[4.Actual Result]: 
6.The file format of the screenshot is displayed at left side of the name.

[5.Reproduction build]: 
Flame 2.2 build(Affected):
Build ID               20150407162504
Gaia Revision          ea735c21bfb0d78333213ff0376fce1eac89ead6
Gaia Date              2015-04-07 20:58:15
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/3f86ddb7f719
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150407.195227
Firmware Date          Tue Apr  7 19:52:39 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build (Affected):
Build ID               20150407160201
Gaia Revision          84cbd4391fb7175d5380fa72c04d68873ce77e6d
Gaia Date              2015-04-07 17:33:14
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/078128c2600a
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150407.193600
Firmware Date          Tue Apr  7 19:36:12 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
15671

Comment 1

[Lancy(Leave from Mozilla)]

Attachment: Screenshot_notification.png

Comment 2

[Delphine Lebédel [:delphine - Use needinfo]]

P1 -- nominating since screenshot name looks completely wrong (.png should not appear at left of word! Text should remain as in LTR here)

Comment 3

[[e-mail], [e-mail]]

Take over the RTL issue.

Comment 4

[[e-mail], [e-mail]]

Attachment: 2015-04-09-21-21-09.png

Hi Lancy, I cannot reproduce the issue with my locale production build. Could you please give more info for me? Thanks.

Comment 5

[Dylan Oliver [:doliver]]

I'm also unable to reproduce on today's 2.2 build.

Comment 6

[[e-mail], [e-mail]]

Thanks for Dylan's re-check here.

Comment 7

[Lancy(Leave from Mozilla)]

(In reply to Ian Liu [:ianliu] from comment #4)
> Created attachment 8590744 [details]
> 2015-04-09-21-21-09.png
> 
> Hi Lancy, I cannot reproduce the issue with my locale production build.
> Could you please give more info for me? Thanks.

Hi Ian Liu,

Send the screenshot with default name from another device to the test device, complete the transmission and observe the prompt in Notifications, you can see the name is shown wrong.
Refer to the video: Verify1_Notification.mp4.
Please contact me if you have any questions.

This issue still exist on the latest Flame 2.2 and Flame 3.0 build.

Flame 2.2 build(Affected):
Build ID               20150412002502
Gaia Revision          cec00d643f517ffd96cde559cd3bbd43ab85816c
Gaia Date              2015-04-10 21:41:12
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5005522fd68e
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150412.040730
Firmware Date          Sun Apr 12 04:07:41 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build(Affected):
Build ID               20150412160203
Gaia Revision          3c68964cb9fdba7cf0f6829b7f44562acaf1f1d7
Gaia Date              2015-04-10 14:38:19
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0a46652bd992
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150412.192808
Firmware Date          Sun Apr 12 19:28:21 EDT 2015
Bootloader             L1TC000118D0

Comment 8

[Lancy(Leave from Mozilla)]

Attachment: Verify1_Notification.mp4

Comment 9

[[e-mail], [e-mail]]

Thanks. Per Lancy's verification in comment 7, reopen the issue.

Comment 10

[[e-mail], [e-mail]]

Looks like the issue is relative with the default file name of screen shot. And the syntax make the text to be RTL.

Comment 11

[GitHub Autolander Bot]

Attachment: [gaia] ian-liu:notification/bug1152227_support_bi_direction_text_in_message_detail > mozilla-b2g:master

Comment 12

[[e-mail], [e-mail]]

Comment on attachment 8592072 [details] [review]
[gaia] ian-liu:notification/bug1152227_support_bi_direction_text_in_message_detail > mozilla-b2g:master

Hi Zibi,

I see you work on Bug 1137593. The patch here is a little bit relative with Bug 1137593. But the root cause is supporting bi-direction text in the message detail of notification. Could you please help to review my patch? Thanks.

Comment 13

[[e-mail], [e-mail]]

Comment on attachment 8592072 [details] [review]
[gaia] ian-liu:notification/bug1152227_support_bi_direction_text_in_message_detail > mozilla-b2g:master

Since it's a 2.2+ blocking issue, I nominate Alive to be the reviewer to improve reviewing process.

Alive, could you please help to review my pull request? Thanks.

Comment 14

[Zibi Braniecki [:zbraniecki][:gandalf]]

Hi Ian, I left you a comment in the PR.

Comment 15

[[e-mail], [e-mail]]

Zibi, I have updated the patch with your suggestion.

Comment 16

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8592072 [details] [review]
[gaia] ian-liu:notification/bug1152227_support_bi_direction_text_in_message_detail > mozilla-b2g:master

Deliver review to Michael.

Comment 17

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8592072 [details] [review]
[gaia] ian-liu:notification/bug1152227_support_bi_direction_text_in_message_detail > mozilla-b2g:master

r+ on the toaster detail part.

The notification message part we should no longer need now that bug 1152230 landed. I believe the utility tray part is fixed on master now. If you still need to modify notifications.js in some way though, please reflag me.

Comment 18

[Zibi Braniecki [:zbraniecki][:gandalf]]

I don't think you need to change anything in notifications.js. Left a comment in PR

Comment 19

[[e-mail], [e-mail]]

Update the patch without notifications.js changed. And I do manual test with the patch rebased. The notification message part is displayed normally now. Wait Zibi's final reviewing process. Thanks.

Comment 20

[[e-mail], [e-mail]]

Since the patch is landed, we can close the issue now.

Gaia/master: https://github.com/mozilla-b2g/gaia/commit/3be562701d5b276ff2ac46a5e9fbd63a9b378d4d

Comment 21

[[e-mail], [e-mail]]

Comment on attachment 8592072 [details] [review]
[gaia] ian-liu:notification/bug1152227_support_bi_direction_text_in_message_detail > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Support RTL
[User impact] if declined: The file name of notification toast is not normal in RTL.
[Testing completed]: Manual test
[Risk to taking this patch] (and alternatives if risky): Very low
[String changes made]: None

Comment 22

[Sue]

Attachment: v3.0_verified_pass.png

This issue has been verified passed on latest build of Flame 3.0 with the same steps in comment 0.
See attachment:v3.0_verified_pass.png
Rate:0/5

Device: Flame 3.0 (pass)
Build ID               20150421160203
Gaia Revision          15134b080b5f406e5aa36f5136c17dafb4e31f64
Gaia Date              2015-04-21 19:52:45
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/86725d1a2cf3
Gecko Version          40.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150421.192130
Firmware Date          Tue Apr 21 19:21:42 EDT 2015
Bootloader             L1TC000118D0

Comment 23

[Sue]

Attachment: v3.0_verified_pass.png

Comment 24

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/27d7c751f474f379cc2d2d328509c30c6b4cf5a8

Comment 25

[Sue]

Attachment: verified_pass.png

This issue has been verified passed on latest build of Flame 2.2 and Nexus_5 2.2/3.0 with the same steps in comment 0.
See attachment:verified_pass.png
Rate:0/5

Device: Flame 2.2 (pass)
Build ID               20150423162502
Gaia Revision          b838d0e7c163e66660dcb6e387d8339944a7a30e
Gaia Date              2015-04-23 02:32:46
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5fe76b26e55f
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150423.195827
Firmware Date          Thu Apr 23 19:58:39 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 2.2 (pass)
Build ID               20150423002502
Gaia Revision          b838d0e7c163e66660dcb6e387d8339944a7a30e
Gaia Date              2015-04-23 02:32:46
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8dce56574f28
Gecko Version          37.0
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150423.035409
Firmware Date          Thu Apr 23 03:54:27 EDT 2015
Bootloader             HHZ12f

Device: Nexus 5 3.0 (pass)
Build ID               20150423160207
Gaia Revision          0c5e2ee1173f3c53379ef3cd10de714836258fe8
Gaia Date              2015-04-23 16:10:10
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/22a157f7feb7
Gecko Version          40.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150423.192918
Firmware Date          Thu Apr 23 19:29:36 EDT 2015
Bootloader             HHZ12f