1152236 - Gonk PlatformDecoderModule is broken.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Alfredo Yang (:alfredo)]

Enable Gonk PlatformDEcoderModule and play a mp4 file from browser. It fails to play.

04-08 05:36:18.096 I/PRLog   ( 2900): 2015-04-08 09:36:18.109155 UTC - -1199926664[b1dd5900]: MP4Reader(b1520800)::void mozilla::MP4Reader::Update(mozilla::MP4Reader::TrackType): Update(Video) ni=1 no=1 iex=0 fl=0
04-08 05:36:18.096 I/PRLog   ( 2900): 2015-04-08 09:36:18.112842 UTC - -1199922576[afac9880]: MP4Reader(b1520800)::void mozilla::MP4Reader::ScheduleUpdate(mozilla::MP4Reader::TrackType): SchedulingUpdate(Video)
04-08 05:36:18.096 I/PRLog   ( 2900): 2015-04-08 09:36:18.112918 UTC - -1199926664[b1dd5900]: MP4Reader(b1520800)::void mozilla::MP4Reader::Update(mozilla::MP4Reader::TrackType): Update(Video) ni=1 no=1 iex=0 fl=0
04-08 05:36:18.106 I/PRLog   ( 2900): 2015-04-08 09:36:18.116729 UTC - -1199922576[afac9880]: MP4Reader(b1520800)::void mozilla::MP4Reader::ScheduleUpdate(mozilla::MP4Reader::TrackType): SchedulingUpdate(Video)
04-08 05:36:18.106 I/PRLog   ( 2900): 2015-04-08 09:36:18.116824 UTC - -1199926664[b1dd5900]: MP4Reader(b1520800)::void mozilla::MP4Reader::Update(mozilla::MP4Reader::TrackType): Update(Video) ni=1 no=1 iex=0 fl=0
04-08 05:36:18.106 I/PRLog   ( 2900): 2015-04-08 09:36:18.124219 UTC - -1199922576[afac9880]: MP4Reader(b1520800)::void mozilla::MP4Reader::ScheduleUpdate(mozilla::MP4Reader::TrackType): SchedulingUpdate(Video)
04-08 05:36:18.106 I/PRLog   ( 2900): 2015-04-08 09:36:18.124337 UTC - -1199926664[b1dd5900]: MP4Reader(b1520800)::void mozilla::MP4Reader::Update(mozilla::MP4Reader::TrackType): Update(Video) ni=1 no=1 iex=0 fl=0
04-08 05:36:18.116 E/OMX-VDEC-1080P(  200):
04-08 05:36:18.116 E/OMX-VDEC-1080P(  200): ERROR: Sending OMX_EventError to Client
04-08 05:36:18.116 E/ACodec  ( 2900): [OMX.qcom.video.decoder.avc] ERROR(0x80001009)
04-08 05:36:18.116 E/MediaCodec( 2900): Codec reported an error. (omx error 0x80001009, internalError -2147483648)
04-08 05:36:18.116 D/GonkVideoDecoderManager( 2900): Decoder failed, err=-38
04-08 05:36:18.116 D/GonkMediaDataDecoder( 2900): Failed to output data
04-08 05:36:18.116 D/GonkMediaDataDecoder( 2900): Callback error!


It looks like OMX video codec rejects the input sample.

Comment 1

[Jean-Yves Avenard [:jya]]

is this a regression ?

Comment 2

[Alfredo Yang (:alfredo)]

I think so, it was ok at last week. I'm bisecting the changelist.

Comment 3

[Alfredo Yang (:alfredo)]

Bad news, 237908 is good, 237910 isn't.

Comment 4

[Alfredo Yang (:alfredo)]

Attachment: use_annex_b_for_omx

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8590114 [details] [diff] [review]
use_annex_b_for_omx

Review of attachment 8590114 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry for that...

Comment 6

[Jean-Yves Avenard [:jya]]

(In reply to Alfredo Yang from comment #3)
> Bad news, 237908 is good, 237910 isn't.

Those revisions are unlikely going to be global... Should use the hash instead.

Comment 7

[Alfredo Yang (:alfredo)]

One line changed on gonk kk so it won't break other platforms.
It won't break any testcase because try-run on emulator-kk doesn't work yet. :(

Comment 8

[Jean-Yves Avenard [:jya]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/59247aa975ee

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/59247aa975ee

Comment 10

[Alfredo Yang (:alfredo)]

It happens again on m-c. :(
Not only MSE but also mp4 playback fails.

changeset:   256394:07befc6f54e7

Comment 11

[Alfredo Yang (:alfredo)]

The problem is decoder enters dormant state because mOwner->IsHidden() is true.

https://dxr.mozilla.org/mozilla-central/source/dom/media/MediaDecoder.cpp#202

Comment 12

[Alfredo Yang (:alfredo)]

It sets dormant to false later but mDecodingFrozenAtStateDecoding is true. That stops playback.

https://dxr.mozilla.org/mozilla-central/source/dom/media/MediaDecoderStateMachine.cpp#1507

Comment 13

[Alfredo Yang (:alfredo)]

mQueuedSeek is not pending when returning from dormant state so the decoding won't start.
The root cause is different with this bug. I'll create another bug.

[1] https://dxr.mozilla.org/mozilla-central/rev/d6ea652c579992daa9041cc9718bb7c6abefbc91/dom/media/MediaDecoderStateMachine.cpp#1327

Comment 14

[Alfredo Yang (:alfredo)]

Bug 1192694