Closed Bug 1152243 Opened 9 years ago Closed 8 years ago

[Super Search] Add an icon to links that add terms to the current search

Categories

(Socorro :: Webapp, task)

Product:
Socorro
Component:
Webapp
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: adrian, Assigned: thalia.e.chan)

References

Details

On a suggestion of Tchanders: 

> Perhaps it would make more sense to add icons (e.g. a plus) to the left of the search terms, to indicate that they are not links, but filters?
I often end up doing a middle-click on the signature as from other reports I'm used to that opening a new tab with report/list, but on the Super Search page, that ends up opening a new tab with the same search as the current one, so I'd call that fail on all sides. I'm not sure that an icon would make it clearer that this link doesn't what you'd expect a link to do.
So should we instead have a different behavior on signatures in the Super Search page? That means all terms but signatures would get added to the current search when clicked. Wouldn't that be weird? Or maybe we can do something else, I'm open to suggestions.
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/2b502dc9f3e85e6c57bc58b9039c7a1405dc3d8c
Bug 1152243 Add an icon to links that add terms to the current search

Also add crash-id class

https://github.com/mozilla/socorro/commit/1a2164be2eea791f032a2993ea36f0a9bf89ce8e
Merge pull request #2726 from Tchanders/term-icons

Bug 1152243 Add an icon to links that add terms to the current search
Assignee: nobody → thalia.e.chan
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
I'm not crazy about the '+' signs but I can live with them if it's really a popular demand.

I have a similar problem as KaiRo in comment 1. I try to middle-click to get a new tab with the filter added (while keeping the current search on the current tab). It has failed on me so many times that I should know better, but I still keep falling for it; I guess it's just my instinctive expectation for middle-click.

Also I think this changed caused bug 1160343, but that can be fixed independently.
Depends on: 1160343
Seeing this on prod now, I find things hard to read with this change.

It's really interesting to see how much the eyes get caught up when you have that "signature report" string interleaved with the signatures you read or glance over.

Still, the current layout makes me think what I'd really want there is to have the signature itself linked to the signature report and the current functionality be put on on clicking the "+" sign there.
dmajor and kairo have asked me to revert this on prod for the moment.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/9276976c6048bc3dc03be00299065d529876401c
Revert "Bug 1152243 Add an icon to links that add terms to the current search"

This reverts commit 2b502dc9f3e85e6c57bc58b9039c7a1405dc3d8c.

https://github.com/mozilla/socorro/commit/751e05bde233dcbde683964907cb53b6b662261d
Merge pull request #2764 from rhelmer/bug1152243-revert-icon-supersearch-ui-change

Revert "Bug 1152243 Add an icon to links that add terms to the current s...
:Tchanders do you want to work on this again?
Sure, I'm happy to work on this. Popular consensus seems to be that we keep the signatures linking to the signature reports. In that case, the two main problems are (a) that the links and filters look the same and (b) that we need a new way to add the signature report as a filter. Possible solutions:

1. Take the link styling off the filters and add a '+' icon for each filter term, including the signature. This solves (a) and (b) but might make the table rows more crowded and/or taller. (Similar to what was reverted, but with the signatures linking to the signature reports.)

2. Take the link styling off the filters and use some other style, such as a border and a pointer cursor, to indicate that they are filters. For the signature filter, have 'Add signature filter', styled like the other filters. This solves (a) and (b) without introducing a load of icons.

Would either of these approaches work?
I'm not a huge fan of an approach that removes link styling. Conceptually those items seem like links to me. (And I think that's why I hopelessly try to middle-click all the time.)

Can we solve this problem from the other direction? In other words, can we make filters act like links? Basically, links that go to the same URL but with &whatever=theThingIClicked. (You could do fancy things for the intra-page case to avoid an actual navigation) Then at least the middle-click and new tab cases would work.

Any thoughts? I would especially like to hear from KaiRo because if this is in conflict with his workflow then I'll back off.
Flags: needinfo?(kairo)
I'd be OK with what David says.

What I could also imagine would be to always add a "+" (including to other facets) and only link that to adding filters while linking the signature itself to the signature report, and don't link non-signature facets at all.
Flags: needinfo?(kairo)
(In reply to David Major [:dmajor] from comment #10)
> Can we solve this problem from the other direction? In other words, can we
> make filters act like links? Basically, links that go to the same URL but
> with &whatever=theThingIClicked. (You could do fancy things for the
> intra-page case to avoid an actual navigation) Then at least the
> middle-click and new tab cases would work.

Interestingly, there's indeed a bug in the facet tabs. But if you try those links in the Crash Reports tab, you'll see that it works just as you describe it. So yeah, let's fix that for facet tabs. 

We have a special case for the crash ID, that is a link to the report/index page. We can add a new special case for the signature field, to have the actual signature be a link to the signature report page, and replace the "Signature report" link with something like "Add term" to add the term to the current search form. Would that work?
If the add-term functionality is still available somehow, then that sounds fine to me.
Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/ee86834877ea760a25a05c11a62098057afed542
Bug 1152243 Make signature links on search go to report pages

Also make 'Add term' link for signatures and bring back '+' icons for search terms, but without line breaks this time

https://github.com/mozilla/socorro/commit/ff3241b22e2c5dcef709dec1e428753bdb0ca4a2
Merge pull request #2808 from Tchanders/searchlinks

Bug 1152243 Make signature link in supersearch results go to signatur…
Depends on: 1169375
Pretty sure we have that little "+" now in from of the "Add item" link. Adrian, still a valid bug?
Flags: needinfo?(adrian)
Status: REOPENED → RESOLVED
Closed: 9 years ago → 8 years ago
Flags: needinfo?(adrian)
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.