Closed Bug 1152287 Opened 10 years ago Closed 10 years ago

TEST-UNEXPECTED-FAIL | crypto | Failed to find the appropraite data_path

Categories

(MailNews Core :: Security: S/MIME, defect)

Product:
MailNews Core
Component:
Security: S/MIME
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird38 fixed, thunderbird39 fixed, thunderbird40 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 40.0
Tracking Flags:
Tracking Status
thunderbird38 --- fixed
thunderbird39 --- fixed
thunderbird40 --- fixed

People

(Reporter: aryx, Assigned: jcranmer)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Move the test to an xpcshell test
7.76 KB, patch
rkent
: review+
rkent
: approval-comm-beta+
Details | Diff | Splinter Review
Fallout from bug 1054308? The test passes locally, so has the config on the test servers changed that the relative folder paths in wrapper.py don't match anymore? https://dxr.mozilla.org/comm-central/source/mail/test/mozmill/crypto/wrapper.py#22 Bonus for fixing the typo in the error message.
The only reason why this test was a Mozmill test was to encourage writing Mozmill tests for S/MIME. Quite frankly, it's easier to understand as an xpcshell test, and having a test that looks like it's testing UI when it's really testing some backend API is surprising both for people working on this code and for people looking at what code is covered. It's also proof of how balls-and-strings our test packaging is for mozmill...
Assignee: nobody → Pidgeot18
Status: NEW → ASSIGNED
Attachment #8591388 - Flags: review?(rkent)
Comment on attachment 8591388 [details] [diff] [review] Move the test to an xpcshell test Looks good to me, and runs successfully locally.
Attachment #8591388 - Flags: review?(rkent) → review+
https://hg.mozilla.org/comm-central/rev/fe7caa9e9426
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
Comment on attachment 8591388 [details] [diff] [review] Move the test to an xpcshell test [Approval Request Comment] Regression caused by (bug #): User impact if declined: Testing completed (on c-c, etc.): Risk to taking this patch (and alternatives if risky): We're seeing this in TB 38, so let's uplift.
Attachment #8591388 - Flags: approval-comm-beta?
Comment on attachment 8591388 [details] [diff] [review] Move the test to an xpcshell test THUNDERBIRD_38_VERBRANCH (TB38): https://hg.mozilla.org/releases/comm-beta/rev/f902a0828c71 comm-beta default (TB39): https://hg.mozilla.org/releases/comm-beta/rev/3390e06188c1
Attachment #8591388 - Flags: approval-comm-beta? → approval-comm-beta+
Depends on: 1180508
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: