Closed
Bug 1152296
Opened 9 years ago
Closed 9 years ago
Move roomStore.js from content/shared/js to content/js
Categories
(Hello (Loop) :: Client, defect)
Hello (Loop)
Client
Tracking
(firefox40 fixed)
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: standard8, Assigned: standard8)
Details
Attachments
(1 file, 2 obsolete files)
13.03 KB,
patch
|
mikedeboer
:
review+
|
Details | Diff | Splinter Review |
roomStore.js is a desktop-only file, yet we currently have it in shared. This gets confusing at times (it just caught me out again, as I thought I had to be compatible with old versions, when I didn't), and also causes unnecessary bumps of loop-client. Hence, lets just get the move out the way.
Assignee | ||
Comment 1•9 years ago
|
||
Simple patch, does the move and updates the relevant files.
Attachment #8589602 -
Flags: review?(mdeboer)
Comment 2•9 years ago
|
||
Comment on attachment 8589602 [details] [diff] [review] Move roomStore.js from shared code to desktop specific code for Loop. Review of attachment 8589602 [details] [diff] [review]: ----------------------------------------------------------------- +1, but you forgot to hg mv the roomStore.js file here...
Attachment #8589602 -
Flags: review?(mdeboer) → review-
Assignee | ||
Comment 3•9 years ago
|
||
Ok, that was git-bz messing that up. This should work better.
Attachment #8589602 -
Attachment is obsolete: true
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8589627 [details] [diff] [review] Move roomStore.js from shared code to desktop specific code for Loop. v2 Actually, I think its splinter messing up the display - try looking at the details/raw patch.
Attachment #8589627 -
Flags: review?(mdeboer)
Assignee | ||
Comment 5•9 years ago
|
||
Ok, this is less git-generated. Lets see if this shows up in splinter.
Attachment #8589627 -
Attachment is obsolete: true
Attachment #8589627 -
Flags: review?(mdeboer)
Attachment #8589629 -
Flags: review?(mdeboer)
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to Mark Banner (:standard8) from comment #5) > Created attachment 8589629 [details] [diff] [review] > Move roomStore.js from shared code to desktop specific code for Loop. v3 > > Ok, this is less git-generated. Lets see if this shows up in splinter. Nope, because there's bug 905060.
Comment 7•9 years ago
|
||
Comment on attachment 8589629 [details] [diff] [review] Move roomStore.js from shared code to desktop specific code for Loop. v3 Review of attachment 8589629 [details] [diff] [review]: ----------------------------------------------------------------- :) Alright, I see the rename in the raw diff.
Attachment #8589629 -
Flags: review?(mdeboer) → review+
Updated•9 years ago
|
Flags: firefox-backlog+
Assignee | ||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/d6a8f02212b8
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•