1152330 - Avoid to add listener from rulers highlighter to content window

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[Matteo Ferretti [:zer0] [:matteo]]

Currently the rulers adds a couple of listeners to the content window; that should be avoided.

Comment 1

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Avoid to add listener from rulers highlighter to content window

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8639333 [details] [diff] [review]
Avoid to add listener from rulers highlighter to content window

Changing reviewer 'cause Patrick will be on PTO for a while.

Mike, can you have a look at that? If you don't feel comfortable to review this, just let me know! Thanks!

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Avoid to add listener from rulers highlighter to content window

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8646765 [details] [diff] [review]
Avoid to add listener from rulers highlighter to content window

Comparing to the previous patch, I just added the try / catch block I mentioned on vidyo. My mistake was that I was using a `finally` initially instead of a `catch`; without realizing that it was a nested `try` statement – therefore the enclosing try statement's catch clause was entered.

Where this patch will indeed solve the issue when we leave the tests – at least locally, I'm running on try too – we should probably understand what is happening with the highlighter environment, and why is destroyed before the highlighter.

Comment 5

[Matteo Ferretti [:zer0] [:matteo]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7174c6e46fb

There is an exception, but it doesn't seems related to this bug.

Comment 6

[Patrick Brosset <:pbro>]

What about if in CustomHighlighterActor.prototype.finalize you reverse the environment and highlighter destroys?

  finalize: method(function() {
    if (this._highlighter) {
      this._highlighter.destroy();
      this._highlighter = null;
    }

    if (this._highlighterEnv) {
      this._highlighterEnv.destroy();
      this._highlighterEnv = null;
    }
  }, {
    oneway: true
  })

Tried this quickly locally, and the exception seems to be gone.

Comment 7

[Matteo Ferretti [:zer0] [:matteo]]

(In reply to Patrick Brosset [:pbrosset] [:pbro] from comment #6)

> What about if in CustomHighlighterActor.prototype.finalize you reverse the
> environment and highlighter destroys?

This is definitely the culprit then; I was looking at `HighlighterActor`, where the order is correct (the highlighter is destroyed before the environment).

> Tried this quickly locally, and the exception seems to be gone.

Should we remove the try / catch then, and invert the order in `CustomHighlighterActor`?

Comment 8

[Patrick Brosset <:pbro>]

(In reply to Matteo Ferretti [:matteo] [:zer0] from comment #7)
> Should we remove the try / catch then, and invert the order in
> `CustomHighlighterActor`?
Yes, that's the right thing to do.

Comment 9

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Avoid to add listener from rulers highlighter to content window

Comment 10

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 8649318 [details] [diff] [review]
Avoid to add listener from rulers highlighter to content window

I thought I've already updated this patch, but apparently I didn't.

Here also the try result:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=3d780dde0c02

Comment 11

[Patrick Brosset <:pbro>]

Comment on attachment 8649318 [details] [diff] [review]
Avoid to add listener from rulers highlighter to content window

Review of attachment 8649318 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5fb2d9aa3f3b

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/5fb2d9aa3f3b

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5fb2d9aa3f3b