1152352 - The click frequency cap on suggested tiles does not work with e10s

Status: RESOLVED WORKSFORME

(Firefox :: New Tab Page, defect)

Comment 1

[Marina Samuel [:emtwo]]

Clicking a suggested tile should make it no longer appear in the new tab set of tiles. The click does not register with e10s and the suggested tile continues to appear after it's clicked.

Comment 2

[Ursula Sarracini (:ursula)]

This can't be reproduced when the newtab page isn't running in e10s, but when it does what it looks like is happening is that after the suggested link has been clicked and new links are fetched from the parent in order to refresh the grid for the next newtab, the suggested link hasn't been cleared and marked as a "history" link instead of a "suggested" link, so when the child requests new links it'll get the old set of links with the suggested one still in there

Comment 3

[Ursula Sarracini (:ursula)]

I can't reproduce this on currently Nightly, when about:newtab isn't running in e10s. Maybe something got fixed along the way...are you able to reproduce?

It's still broken when about:newtab runs in e10s but the patch to fix this can be folded into the patch for Bug 1021654.

Comment 4

[Marina Samuel [:emtwo]]

Yea this is just an e10s bug. I am fine with merging the fix for this bug into Bug 1021654

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Out of sheer curiosity, how did you know this was going to be broken? This bug was filed 2015-04-08, which was before ursula started on porting about:newtab to e10s.

Comment 6

[Marina Samuel [:emtwo]]

This bug is unrelated to porting about:newtab to e10s. The bug was appearing in the original about:newtab with e10s enabled.

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Ah, okay, so to summarize:

- This bug existed with e10s enabled on 2015-04-08
- Since that time, this bug has somehow been fixed - we no longer see its symptoms in Nightly with e10s enabled
- The patch that makes about:newtab run remotely seems to re-open this bug, but ursula will be folding her patch in to fix it with those about:newtab patches.

Is that correct? I'm just trying to make sure I understand correctly. :)

Comment 8

[Marina Samuel [:emtwo]]

Ah ok, I didn't know it was fixed in current nightly. But in that case, that sounds about right. :)

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Are you able to confirm that it's fixed in current Nightly? ursula and I are reasonably certain, but we wanted to be sure to check with you, as you filed the bug.

Comment 10

[Marina Samuel [:emtwo]]

I've confirmed that I no longer see this bug in Nightly

Comment 11

[Ursula Sarracini (:ursula)]

I'll mark this as works for me and I'll put the fix for e10s bustage in the patch for Bug 1021654