115237 - Crash by more than one download of newsgroup for offline use

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect)

Description

[Daniel]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.6+) Gecko/20011213
BuildID:    2001121312



Reproducible: Sometimes
Steps to Reproduce:
If you go to the properties of a subscribed newsgroup --> offline
activate  "Select this NG for offline use" AND do Download now.

Now do this with many NG at the same time. By downloading more than three NG
mozilla will mostly crash. (On my system the talkback didn't start.) If it don't
crashs: click to the inbox of your mailbox. It doesn't work always. Try a little.



Actual Results:  crash!

I downloading the messages by 768kBit/s. Maybe you need an especially speed for
crashing?

Comment 1

[David :Bienvenu]

Do you mean something like the following:

1. bring up properties on a newsgroup; do a download now.
2. While that's going on, bring up properties on another newsgroup, and do a
download now.
3. While both of those are still going on, repeat, until we crash?

Comment 2

[David :Bienvenu]

OK, I've reproduced this. This is happening because the mDatabase of the
newsfolder is getting set to null out from under the news download code when we
switch folders. I was afraid something like this was going to happen. The fix is
probably to change the code where we're crashing to do a GetDatabase instead of
counting on mDatabase getting set.  

Comment 3

[grylchan]

confirmerd in 2001-12-14-09-trunk on nt 4.0

talkback TB484339X

stack trace
nsMsgDBFolder::EndNewOfflineMessage 
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgDBFolder.cpp, line 1352] 
nsMsgNewsFolder::NotifyDownloadedLine 
[d:\builds\seamonkey\mozilla\mailnews\news\src\nsNewsFolder.cpp, line 1696] 
nsNNTPProtocol::ReadArticle 
[d:\builds\seamonkey\mozilla\mailnews\news\src\nsNNTPProtocol.cpp, line 2627] 
nsNNTPProtocol::ProcessProtocolState 
[d:\builds\seamonkey\mozilla\mailnews\news\src\nsNNTPProtocol.cpp, line 5183] 
nsMsgProtocol::OnDataAvailable 
[d:\builds\seamonkey\mozilla\mailnews\base\util\nsMsgProtocol.cpp, line 263] 
nsOnDataAvailableEvent::HandleEvent 
[d:\builds\seamonkey\mozilla\netwerk\base\src\nsStreamListenerProxy.cpp, line 
203] 
PL_HandleEvent [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 591] 
PL_ProcessPendingEvents [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, 
line 524] 
_md_EventReceiverProc [d:\builds\seamonkey\mozilla\xpcom\threads\plevent.c, line 
1072] 

Comment 4

[David :Bienvenu]

it's not critical, imo - you have to jump through some hoops to get into this
situation. Anyway, a fix is upcoming.

Comment 5

[Daniel]

Yes, that's what I meant.
I'll try the patch if it is avaiable in the nightly builds.
THNX

Comment 6

[David :Bienvenu]

Attachment: proposed fix

Comment 7

[Navin Gupta]

Comment on attachment 61913 [details] [diff] [review]
proposed fix

r=naving

Comment 8

[David :Bienvenu]

fix checked in.

Comment 9

[grylchan]

Using commercial
2001-12-21-09-trunk nt 4.0
2001-12-21-08-trunk linux 2.2
2001-12-21-04-trunk mac 9.1
2001-12-21-04-trunk mac 10.1

Verified using 'download now' button off the properties menu and
using it to download multiple newsgroups at the same time
results in no crash and news mesgs get downloaded.

Tried different type of newsgroups (some with 4000 mesgs, others
few 100) and no problems. And in middle of download, hitting stop
button resulted in no errors.


marking as verified.

Comment 10

[Michael Buckland]

Adding AOLTW.

Comment 11

[Michael Buckland]

Updating AOLTW.  Making minus.