1152389 - Reconcile our maximum pinboard count error messages

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P5)

Description

[Jonathan French (:jfrench)]

So we have three different "pinboard is full" kinds of messages, encountered with slightly different workflows and code-paths.

I wonder if we could have one code path, or at least, fewer message styles.

To reproduce:
Workflow 1
o start with pinboard, Pin-all icon
dialogue: "Max pinboard size of 500 reached."

Workflow 2
o empty pinboard, Pin-all, remove a few jobs, pin some others until >500
dialogue: "Pinboard is already at maximum size of 500"

Workflow 3
o empty pinboard, Pin-all, Pin-all a 2nd time
dialogue: "Pinboard is full. Can not pin any more jobs"


I wonder if we want to try to make at least the first 2, if not all 3, match each other (possibly with dialogue 1, since we just fixed that in bug 1149576) and perhaps also make these things non-sticky? ie. removing the [x] close UI.

We could also check to see if there are code-path duplications, during the work.

Comment 1

[Jonathan French (:jfrench)]

Attachment: maxPinCountMsgs

Per screen grab.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

There are three different code paths here.
https://github.com/mozilla/treeherder/blob/be8c7be9ad3bf17541849dc8aaf5b051be0d0435/ui/js/controllers/filters.js#L185
https://github.com/mozilla/treeherder/blob/be8c7be9ad3bf17541849dc8aaf5b051be0d0435/ui/js/services/pinboard.js#L75
https://github.com/mozilla/treeherder/blob/e53a3393a2783ec878d3f9c2e55997d42a98458d/ui/js/models/resultsets_store.js#L307

We could easily get each of these to return a single error message, not sure if we could de-duplicate the actual code paths.

Comment 3

[Sarah Clements [:sclements]]

Attachment: Pull request for pinboard error message

Comment 4

[Cameron Dawson [:camd]]

Comment on attachment 8919904 [details] [review]
Pull request for pinboard error message

Just requesting a couple tweaks.  Please reassign to me when you've got them done.

Comment 5

[GitHub Autolander Bot]

Attachment: [treeherder] sarah-clements:pinboard_error_message > mozilla:master

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/dfcb18f84043891c857fe60b4a7bb58341d8b1de
Bug 1152389 - Reconcile pinboard count error messages (#2848)