1152391 - appVersionInfo should use UpdateChannel.jsm to fetch update channel information

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mike de Boer [:mikedeboer]]

Bug 1065153, introduced HAWK request failure report to a URL. This code retrieves the current update channel by directly reading the 'app.update.channel' pref, where it should use UpdateChannel.jsm instead.

Comment 1

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: appVersionInfo should use UpdateChannel.jsm

Comment 2

[Mike de Boer [:mikedeboer]]

Thanks!

Pushed to fx-team as: https://hg.mozilla.org/integration/fx-team/rev/1bf4069d8a69

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1bf4069d8a69

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8590122 [details] [diff] [review]
Patch v1: appVersionInfo should use UpdateChannel.jsm

Approval Request Comment
[Feature/regressing bug #]: Update channel retrieval via a pref was introduced in bug 1065153. This causes issues for the RHEL (Redhat Linux) builds of Fx.
[User impact if declined]: User won't be able to use Loop/ Hello as conversation windows won't open.
[Describe test coverage new/current, TreeHerder]: landed on m-c, tests pass.
[Risks and why]: minor.
[String/UUID change made/needed]: n/a.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Should be 38 beta 3 (or 4)

Comment 6

[Matěj Cepl]

Attachment: bug-1152391-updateChannel.patch

I hope this is the patch for the Firefox 38. Is it right?

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2265bb2e41ed

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/3f5e298cb641

Comment 9

[Mike de Boer [:mikedeboer]]

(In reply to Matěj Cepl from comment #6)
> I hope this is the patch for the Firefox 38. Is it right?

Yes, it is.