Closed Bug 1152391 Opened 5 years ago Closed 5 years ago

appVersionInfo should use UpdateChannel.jsm to fetch update channel information

Categories

(Hello (Loop) :: Client, defect, P1)

defect
Points:
1

Tracking

(firefox38 fixed, firefox39 fixed, firefox40 fixed)

RESOLVED FIXED
mozilla40
Iteration:
40.1 - 13 Apr
Tracking Status
firefox38 --- fixed
firefox39 --- fixed
firefox40 --- fixed

People

(Reporter: mikedeboer, Assigned: mikedeboer)

References

Details

Attachments

(2 files)

Bug 1065153, introduced HAWK request failure report to a URL. This code retrieves the current update channel by directly reading the 'app.update.channel' pref, where it should use UpdateChannel.jsm instead.
Flags: qe-verify-
Flags: firefox-backlog+
Assignee: nobody → mdeboer
Status: NEW → ASSIGNED
Iteration: --- → 40.1 - 13 Apr
Attachment #8590122 - Flags: review?(standard8) → review+
https://hg.mozilla.org/mozilla-central/rev/1bf4069d8a69
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Comment on attachment 8590122 [details] [diff] [review]
Patch v1: appVersionInfo should use UpdateChannel.jsm

Approval Request Comment
[Feature/regressing bug #]: Update channel retrieval via a pref was introduced in bug 1065153. This causes issues for the RHEL (Redhat Linux) builds of Fx.
[User impact if declined]: User won't be able to use Loop/ Hello as conversation windows won't open.
[Describe test coverage new/current, TreeHerder]: landed on m-c, tests pass.
[Risks and why]: minor.
[String/UUID change made/needed]: n/a.
Attachment #8590122 - Flags: approval-mozilla-beta?
Attachment #8590122 - Flags: approval-mozilla-aurora?
Attachment #8590122 - Flags: approval-mozilla-beta?
Attachment #8590122 - Flags: approval-mozilla-beta+
Attachment #8590122 - Flags: approval-mozilla-aurora?
Attachment #8590122 - Flags: approval-mozilla-aurora+
Should be 38 beta 3 (or 4)
I hope this is the patch for the Firefox 38. Is it right?
Flags: needinfo?(mdeboer)
(In reply to Matěj Cepl from comment #6)
> I hope this is the patch for the Firefox 38. Is it right?

Yes, it is.
Flags: needinfo?(mdeboer)
You need to log in before you can comment on or make changes to this bug.