[Crash] [@ nsCOMPtr<imgIContainer>::nsCOMPtr ]

RESOLVED FIXED in 2.2 S12 (15may)

Status

()

defect
RESOLVED FIXED
4 years ago
a month ago

People

(Reporter: ntroast, Assigned: janv)

Tracking

({crash})

unspecified
2.2 S12 (15may)
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:2.2+, b2g-v2.2 fixed, b2g-master fixed)

Details

(Whiteboard: [b2g-crash][caf-crash 476][caf priority: p1][CR 818822])

Attachments

(24 attachments)

143.79 KB, text/plain
Details
540.71 KB, text/plain
Details
143.79 KB, text/plain
Details
540.71 KB, text/plain
Details
136.83 KB, text/plain
Details
467.52 KB, text/plain
Details
103.36 KB, text/plain
Details
450.54 KB, text/plain
Details
84.20 KB, text/plain
Details
423.25 KB, text/plain
Details
140.46 KB, text/plain
Details
467.14 KB, text/plain
Details
139.19 KB, text/plain
Details
454.82 KB, text/plain
Details
82.89 KB, text/plain
Details
431.72 KB, text/plain
Details
141.12 KB, text/plain
Details
458.48 KB, text/plain
Details
139.53 KB, text/plain
Details
466.71 KB, text/plain
Details
9.58 KB, patch
Details | Diff | Splinter Review
3.26 KB, patch
Details | Diff | Splinter Review
114.50 KB, text/plain
Details
404.96 KB, text/plain
Details
(Reporter)

Description

4 years ago
We observed the following crash signature during testing.

[@ nsCOMPtr<imgIContainer>::nsCOMPtr | mozilla::dom::quota::QuotaManager::AbortCloseStoragesForProcess | mozilla::dom::ContentParent::ShutDownProcess | mozilla::dom::ContentParent::ActorDestroy ]

Cafbot will upload the decoded minidump and extra file.

This crash was produced during stability tests which involves monkey testing for several hours and there is no clear STR for this. If we are not able to identify the issue using provided logs then please feel free to provide us a debug patch with additional logging to identify the issue.
Whiteboard: [CR 818822]
Whiteboard: [CR 818822] → [caf priority: p1][CR 818822]
Whiteboard: [caf priority: p1][CR 818822] → [b2g-crash][caf-crash 476][caf priority: p1][CR 818822]
Keywords: crash

Comment 6

4 years ago
Hi Andrew,

Please have Olli or someone else on the DOM team pick this up. This issue is directly impacting our ability to meet our MTBF goal per CAF's testing.

Thanks,
Mike
Component: Stability → DOM
Flags: needinfo?(overholt)
Product: Firefox OS → Core
(Assignee)

Comment 7

4 years ago
Probably the same issue as bug 1150023 or bug 1109363.
Yeah, something about QuotaManager. (I'm not familiar with that at all.)
triage: impacting MTBF
blocking-b2g: 2.2? → 2.2+
Andrew, do you know who can own this bug and take a look? This is a bug in CAF list with higher priority. 
Thank you.
(Assignee)

Comment 11

4 years ago
I can take this.
Assignee: nobody → Jan.Varga
Flags: needinfo?(overholt)
Hey Jan, so you have an eta on the patch here? This is one of the critical blockers for FXOS and hence the eta would be helpful. Please note for crashes like this, debugging patches that can collect more information helpful for investigation are more than helpful.
Flags: needinfo?(Jan.Varga)
(Assignee)

Comment 13

4 years ago
I think this should be now fixed by patch in bug 1109363.
Do you still see the crash with the patch landed ?
Flags: needinfo?(Jan.Varga)
(Assignee)

Comment 17

4 years ago
(In reply to Jan Varga [:janv] from comment #13)
> I think this should be now fixed by patch in bug 1109363.
> Do you still see the crash with the patch landed ?

actually, I meant bug 1150023

(In reply to cafbot (PoC: ggrisco) from comment #14)
> Observed on: 
> 
> Device: msm8909
> Gonk Version: AU_LINUX_GECKO_LF.BR.1.2.3.00.00.00.000.129
> Moz BuildID: 20150409002503

I think that build doesn't contain the fix.
The fix landed on m-c on 2015-04-13.
Depends on: 1150023
(In reply to Jan Varga [:janv] from comment #17)
> (In reply to Jan Varga [:janv] from comment #13)
> > I think this should be now fixed by patch in bug 1109363.
> > Do you still see the crash with the patch landed ?
> 
> actually, I meant bug 1150023
Janv, CAF is using this : https://hg.mozilla.org/releases/mozilla-b2g37_v2_2 as the gecko code base, so the patch needs to land there. Can you please request b2g37 approval on this and make sure it applies on this codebase?
> 
> (In reply to cafbot (PoC: ggrisco) from comment #14)
> > Observed on: 
> > 
> > Device: msm8909
> > Gonk Version: AU_LINUX_GECKO_LF.BR.1.2.3.00.00.00.000.129
> > Moz BuildID: 20150409002503
> 
> I think that build doesn't contain the fix.
> The fix landed on m-c on 2015-04-13.
Flags: needinfo?(Jan.Varga)

Updated

4 years ago
See Also: → 1154445
(Assignee)

Comment 22

4 years ago
I submitted a backport patch in bug 1150023 along with the approval request.
Flags: needinfo?(Jan.Varga)

Updated

4 years ago
See Also: → 1156881
(In reply to cafbot (PoC: ggrisco) from comment #25)
> Created attachment 8595335 [details]
> decoded minidump - AU_LINUX_GECKO_LF.BR.1.2.3.00.00.00.000.135

Hi! Greg,

Just want to clarify,
Is the patch of bug 1150023 in AU_LINUX_GECKO_LF.BR.1.2.3.00.00.00.000.135?

--
Keven
Flags: needinfo?(ggrisco)

Updated

4 years ago
Duplicate of this bug: 1156881
Sorry, I can't tell if RyanVM's landing of Jan's backport in bug 1150023 is in the build referenced in comment 28.

Comment 32

4 years ago
(In reply to Keven Kuo [:kkuo] from comment #26)
> (In reply to cafbot (PoC: ggrisco) from comment #25)
> > Created attachment 8595335 [details]
> > decoded minidump - AU_LINUX_GECKO_LF.BR.1.2.3.00.00.00.000.135
> 
> Hi! Greg,
> 
> Just want to clarify,
> Is the patch of bug 1150023 in AU_LINUX_GECKO_LF.BR.1.2.3.00.00.00.000.135?
> 
> --
> Keven

I looked at the Gecko link from comment 23 and didn't see the change there yet, so I don't think we have it in AU 135 (which should also answer Andrew's question in comment 31).
Flags: needinfo?(ggrisco)

Updated

4 years ago
Duplicate of this bug: 1154445

Comment 37

4 years ago
It looks like bug 1150023 is built into AU 138 where we still see the crash.
Jan, can you provide an update on the activity here? From comment 37, bug 1150023 hasn't resolved the crash.
Flags: needinfo?(Jan.Varga)
(Assignee)

Comment 48

4 years ago
I think we should try to backport patches from bug 1156063 and bug 1157029.
(Assignee)

Comment 49

4 years ago
Posted patch backport1Splinter Review
Flags: needinfo?(Jan.Varga)
(Assignee)

Comment 50

4 years ago
Posted patch backport2Splinter Review
(Assignee)

Comment 51

4 years ago
Due to time constraints I submitted the patches here. They are intended for the b2g37_v2_2 branch.
I only tested on mac by running:
mach xpcshell-test dom/indexedDB
mach mochitest-plain dom/indexedDB
Greg, can you confirm that attachment 8599522 [details] [diff] [review] and attachment 8599523 [details] [diff] [review] were applied to the build that failed in comment 52?
Flags: needinfo?(ggrisco)
Silly me, I checked the code myself. Those patches are definitely not applied to the revision that failed in comment 52.

Please retest with those applied?

Comment 57

4 years ago
The change went into AU144 last night. Comment 52 was from last build’s report. We should get report on the new build in a day or two.
Flags: needinfo?(ggrisco)
How were the results over the weekend with those two patches applied?
Flags: needinfo?(ggrisco)

Comment 59

4 years ago
(In reply to Dylan Oliver [:doliver] from comment #58)
> How were the results over the weekend with those two patches applied?

Another change is causing high instability, preventing us from determining whether these patches are working.  We need to wait a day or two now before giving feedback here.
Flags: needinfo?(ggrisco)

Comment 60

4 years ago
So far we haven't seen this reproduce on AU 148, but we still need to complete the test cycle.  Should know better tomorrow.  Adding ni? for myself to report back.
Flags: needinfo?(ggrisco)

Comment 61

4 years ago
We had enough testing now to feel that this problem is fixed with the two patches applied.  Can we proceed to land those patches?
Flags: needinfo?(ggrisco) → needinfo?(Jan.Varga)
(Assignee)

Comment 62

4 years ago
(In reply to Greg Grisco from comment #61)
> We had enough testing now to feel that this problem is fixed with the two
> patches applied.  Can we proceed to land those patches?

We already tried to land them, but they caused a problem on ASAN builds.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1157029#c30
Flags: needinfo?(Jan.Varga)
Thanks Jan & Ben. If these are relanded, can we then close this bug out? (dupe it to one of those patches or worksforme?)
Flags: needinfo?(Jan.Varga)
It looks like Josh made a branch-specific patch at https://bugzilla.mozilla.org/show_bug.cgi?id=1156063#c38.  Is that the same as the two referenced by Ben here?
Flags: needinfo?(jocheng)
Hi Ben,
The patch in bug 1156063 seems similar to https://hg.mozilla.org/releases/mozilla-aurora/rev/720b046ff520 
but not include https://hg.mozilla.org/releases/mozilla-aurora/rev/7270d0935640.

Could you please help to confirm this? 
Thanks!
Flags: needinfo?(bent.mozilla)
(Assignee)

Comment 67

4 years ago
(In reply to Josh Cheng [:josh] from comment #66)
> Hi Ben,
> The patch in bug 1156063 seems similar to
> https://hg.mozilla.org/releases/mozilla-aurora/rev/720b046ff520 

this patch alone is not sufficient

> but not include
> https://hg.mozilla.org/releases/mozilla-aurora/rev/7270d0935640.

you also need this one to fix the crash properly

> 
> Could you please help to confirm this? 
> Thanks!
Flags: needinfo?(Jan.Varga)
Hi Jan,

Are fix in bug 1156063 same as https://hg.mozilla.org/releases/mozilla-aurora/rev/720b046ff520?

Do we need to backout fix in bug 1156063 and land these 2? or just go and land https://hg.mozilla.org/releases/mozilla-aurora/rev/7270d0935640 will do?
Flags: needinfo?(Jan.Varga)
Josh, I'm not sure what you're asking exactly. The two patches in comment 63 are the ones that I recommend you backport.
Flags: needinfo?(bent.mozilla)
We're going in circles here but it looks to me like both of those patches are landed and the bugs are marked as status-b2g-v2.2:fixed. Can we close this out?

https://bugzilla.mozilla.org/show_bug.cgi?id=1156063#c39
https://bugzilla.mozilla.org/show_bug.cgi?id=1157029#c34
It looks that way to me too.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED

Updated

4 years ago
Flags: needinfo?(jocheng)
Flags: needinfo?(Jan.Varga)
Target Milestone: --- → 2.2 S12 (15may)
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.