1152440 - replace use of `0` with `nullptr` in embedding/components/windowwatcher/nsWindowWatcher.cpp

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(not reading bugmail) Nick Desaulniers [:\n]]

embedding/components/windowwatcher/nsWindowWatcher.cpp

is full of the use of 0 for pointer values instead of nullptr.  We should clean this up.  Good first bug!

Comment 1

[Andrew McCreight [:mccr8]]

Oh, I just noticed this problem, too.  Bug 1130096 is going to clean up the style of this file, so it'll probably bitrot any patch you may have.

Comment 2

[Andrew McCreight [:mccr8]]

Let me know if you have any questions about this. If you aren't actually working on this feel free to just unassign yourself. ;)

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Comment 4

[Andrew McCreight [:mccr8]]

I produced this patch by manually looking at every instance of 0 in the file.

Comment 5

[Andrew McCreight [:mccr8]]

Attachment: Bug 1152440, part 1 - Replace 0 with nullptr in nsWindowWatcher.cpp.

Comment 6

[Andrew McCreight [:mccr8]]

Attachment: Bug 1152440, part 2 - Only declare one variable per line in SizeOpenedWindow.

Also remove a closing */ that snuck in somehow.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/30ca5d860cb9
part 1 - Replace 0 with nullptr in nsWindowWatcher.cpp. r=smaug
https://hg.mozilla.org/integration/autoland/rev/8a5dff408920
part 2 - Only declare one variable per line in SizeOpenedWindow. r=smaug

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/30ca5d860cb9
https://hg.mozilla.org/mozilla-central/rev/8a5dff408920