Closed
Bug 1152440
Opened 9 years ago
Closed 2 years ago
replace use of `0` with `nullptr` in embedding/components/windowwatcher/nsWindowWatcher.cpp
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
103 Branch
Tracking | Status | |
---|---|---|
firefox103 | --- | fixed |
People
(Reporter: nick, Assigned: mccr8)
Details
Attachments
(2 files)
embedding/components/windowwatcher/nsWindowWatcher.cpp is full of the use of 0 for pointer values instead of nullptr. We should clean this up. Good first bug!
Reporter | ||
Updated•9 years ago
|
Assignee: nobody → dbryant
Reporter | ||
Updated•9 years ago
|
Assignee | ||
Comment 1•9 years ago
|
||
Oh, I just noticed this problem, too. Bug 1130096 is going to clean up the style of this file, so it'll probably bitrot any patch you may have.
Assignee | ||
Comment 2•9 years ago
|
||
Let me know if you have any questions about this. If you aren't actually working on this feel free to just unassign yourself. ;)
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
Comment 3•2 years ago
|
||
The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.
Assignee: dbryant → nobody
Assignee | ||
Updated•2 years ago
|
Assignee: nobody → continuation
Assignee | ||
Comment 4•2 years ago
|
||
I produced this patch by manually looking at every instance of 0 in the file.
Assignee | ||
Comment 5•2 years ago
|
||
Assignee | ||
Comment 6•2 years ago
|
||
Also remove a closing */ that snuck in somehow.
Pushed by amccreight@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/30ca5d860cb9 part 1 - Replace 0 with nullptr in nsWindowWatcher.cpp. r=smaug https://hg.mozilla.org/integration/autoland/rev/8a5dff408920 part 2 - Only declare one variable per line in SizeOpenedWindow. r=smaug
Comment 8•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/30ca5d860cb9
https://hg.mozilla.org/mozilla-central/rev/8a5dff408920
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox103:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 103 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•