Make font_size_utils_test.js not depend on requestAnimationFrame timing

RESOLVED FIXED

Status

Firefox OS
Gaia::Components
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: seth, Assigned: seth)

Tracking

unspecified

Firefox Tracking Flags

(b2g-master fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
See bug 1145439 for more details. The short version is that font_size_utils.js uses requestAnimationFrame internally, and in bug 1145439 I'm making changes to requestAnimationFrame timing. That breaks some of the tests in font_size_utils_test.js, which depend on requestAnimationFrame running before they check their results.
Created attachment 8589829 [details] [review]
[gaia] sethfowler:font_size_utils_test-fix > mozilla-b2g:master
Comment on attachment 8589829 [details] [review]
[gaia] sethfowler:font_size_utils_test-fix > mozilla-b2g:master

Thank you for the patch. R=kgrandon

Feel free to add the checkin-needed keyword to this to have autolander land this.
Attachment #8589829 - Flags: review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
(In reply to Autolander from comment #3)
> Autolander could not locate a review from a user within the suggested
> reviewer list. Either the patch author or the reviewer should be in the
> suggested reviewer list.

Oops, that's because it's not inside of a gaia component. I'm going to move this because it's only gaia code if that's alright.
Component: Canvas: 2D → Gaia::Components
Product: Core → Firefox OS
Landing this manually: https://github.com/mozilla-b2g/gaia/commit/8a2642abe8150c067343418dae23d6dcf1e532c0
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-b2g-master: --- → fixed
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.