If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Calendar] split view selector logic into its own file

RESOLVED FIXED

Status

Firefox OS
Gaia::Calendar
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: millermedeiros, Assigned: millermedeiros)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
right now the tabs (today, month, week, day) are handled inside the app.js, including the logic needed to update the current day.

we should really create a new file inside "views/" to store this logic, "app.js" should contain the minimal logic required to bootstrap the app.
(Assignee)

Updated

3 years ago
Assignee: nobody → mmedeiros
(Assignee)

Updated

3 years ago
Blocks: 1118850
(Assignee)

Updated

3 years ago
Blocks: 1021445

Comment 1

3 years ago
Created attachment 8590610 [details] [review]
[gaia] millermedeiros:1152486-split-view-selector > mozilla-b2g:master
(Assignee)

Updated

3 years ago
Attachment #8590610 - Flags: review?(gaye)
Comment on attachment 8590610 [details] [review]
[gaia] millermedeiros:1152486-split-view-selector > mozilla-b2g:master

LGTM!
Attachment #8590610 - Flags: review?(gaye) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed

Updated

3 years ago
Keywords: checkin-needed

Comment 3

3 years ago
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/629097847567e51095a454e7e63186a6e2ac0307

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.