Closed Bug 1152503 Opened 9 years ago Closed 9 years ago

When pushing to a review repo, mozreview should prompt you if you have uncommitted changes and/or are pushing only changesets which have already been pushed

Categories

(MozReview Graveyard :: General, defect)

Product:
MozReview Graveyard
Component:
General
Platform:
x86_64
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Gijs, Unassigned)

Details

+++ This bug was initially created as a clone of Bug #1152496 +++

Once in a while I forget to update a commit (hg commit --amend) and push the same commits that already existed, or push while there are changes in my working dir. Often I don't know that there was an issue until the reviewer says that the new patch misses changes and/or is the same.

It would be nice if mozreview warned (via a local hook into the push command) about uncommitted changes and/or about pushing only unchanged commits that have already been pushed in their current form.

(I don't know if this is the right product/component or not, as there seem to be several involving reviewboard/mozreview)
Forgot to update the summary, oops.
Summary: When uploading a new attachment and marking an old attachment as obsolete, Bugzilla should compare checksums of the new file and old files to make sure that the same file isn't being uploaded → When pushing to a review repo, mozreview should prompt you if you have uncommitted changes and/or are pushing only changesets which have already been pushed
As of a month or two ago, the client will abort if the working copy is dirty. That's part 1.
Part 2 is more-or-less bug 1179552.  I'm going to mark this fixed since we did part 1 and since the other bug already exists.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.