When pushing to a review repo, mozreview should prompt you if you have uncommitted changes and/or are pushing only changesets which have already been pushed

RESOLVED FIXED

Status

MozReview
General
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: Gijs, Unassigned)

Tracking

Details

(Reporter)

Description

3 years ago
+++ This bug was initially created as a clone of Bug #1152496 +++

Once in a while I forget to update a commit (hg commit --amend) and push the same commits that already existed, or push while there are changes in my working dir. Often I don't know that there was an issue until the reviewer says that the new patch misses changes and/or is the same.

It would be nice if mozreview warned (via a local hook into the push command) about uncommitted changes and/or about pushing only unchanged commits that have already been pushed in their current form.

(I don't know if this is the right product/component or not, as there seem to be several involving reviewboard/mozreview)
(Reporter)

Comment 1

3 years ago
Forgot to update the summary, oops.
Summary: When uploading a new attachment and marking an old attachment as obsolete, Bugzilla should compare checksums of the new file and old files to make sure that the same file isn't being uploaded → When pushing to a review repo, mozreview should prompt you if you have uncommitted changes and/or are pushing only changesets which have already been pushed

Comment 2

2 years ago
As of a month or two ago, the client will abort if the working copy is dirty. That's part 1.

Comment 3

2 years ago
Part 2 is more-or-less bug 1179552.  I'm going to mark this fixed since we did part 1 and since the other bug already exists.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.