CCGraphBuilder::NoteChild should pass aEdgeName by reference, not value

RESOLVED FIXED in Firefox 40

Status

()

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

Trunk
mozilla40
Points:
---

Firefox Tracking Flags

(firefox40 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
dmajor noticed this.  I think this is just a mistake when I wrote this code in bug 730357.
That call to the copy constructor helped me find my bearings in a garbled disassembly dump, so at least it was useful for something ;-)
(Assignee)

Comment 2

4 years ago
Haha.
(Assignee)

Updated

4 years ago
Assignee: nobody → continuation
(Assignee)

Comment 3

4 years ago
Created attachment 8590465 [details] [diff] [review]
CCGraphBuilder::NoteChild should pass aEdgeName by reference.

The try run hasn't finished yet, but I can't imagine there will be any problems.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d05c0fa7339e
Attachment #8590465 - Flags: review?(bugs)

Updated

4 years ago
Attachment #8590465 - Flags: review?(bugs) → review+
(Assignee)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c6fcd3ac3679
Status: NEW → RESOLVED
Last Resolved: 4 years ago
status-firefox40: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in before you can comment on or make changes to this bug.