1152505 - CCGraphBuilder::NoteChild should pass aEdgeName by reference, not value

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

dmajor noticed this.  I think this is just a mistake when I wrote this code in bug 730357.

Comment 1

[(Away)]

That call to the copy constructor helped me find my bearings in a garbled disassembly dump, so at least it was useful for something ;-)

Comment 2

[Andrew McCreight [:mccr8]]

Haha.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: CCGraphBuilder::NoteChild should pass aEdgeName by reference.

The try run hasn't finished yet, but I can't imagine there will be any problems.

try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d05c0fa7339e

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c6fcd3ac3679

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c6fcd3ac3679