Closed
Bug 1152505
Opened 9 years ago
Closed 9 years ago
CCGraphBuilder::NoteChild should pass aEdgeName by reference, not value
Categories
(Core :: XPCOM, defect)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
Details
Attachments
(1 file)
|
933 bytes,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
dmajor noticed this. I think this is just a mistake when I wrote this code in bug 730357.
That call to the copy constructor helped me find my bearings in a garbled disassembly dump, so at least it was useful for something ;-)
|
Assignee | |
Comment 2•9 years ago
|
||
Haha.
|
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → continuation
|
|
Assignee | |
Comment 3•9 years ago
|
||
The try run hasn't finished yet, but I can't imagine there will be any problems. try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d05c0fa7339e
Attachment #8590465 -
Flags: review?(bugs)
|
||
Updated•9 years ago
|
Attachment #8590465 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Updated•9 years ago
|
Keywords: checkin-needed
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6fcd3ac3679
Keywords: checkin-needed
|
||
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c6fcd3ac3679
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•