1152526 - Update Cardview related imagecompare test case

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[No-Jun Park [:njpark]]

Since currently the orientation change support is disabled per Bug 1118390, the imagecompare tests should accommodate it

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] npark-mozilla:1152526 > mozilla-b2g:master

Comment 2

[No-Jun Park [:njpark]]

I ran it 10 times each, and it did not cause the timing related issue I used to see from the delay in loading apps initially.

Comment 3

[Martijn Wargers (dead)]

Comment on attachment 8589990 [details] [review]
[gaia] npark-mozilla:1152526 > mozilla-b2g:master

Without this pull request, I was unable to complete the test at, getting this error:
TEST-UNEXPECTED-ERROR | test_cards_view_kill_apps_with_two_apps.py TestCardsViewTwoApps.test_cards_view_kill_apps_with_two_apps | NoSuchElementException: NoSuchElementException: Unable to locate element: #cards-view li[data-origin*="gallery"]

With this pull request, it passes.

I'm having some reservations about the time.sleep() calls that are used. In the Gaia UI tests, we're supposed to limit the usage of those as much as possible, afaik.

Comment 4

[No-Jun Park [:njpark]]

In this instance, the sleep() is used to represent the amount of time a user spends after opening an app and decides to go back to the homescreen. It is reasonable to assume that user will wait at least the app is completely loaded, before decides to go back to the homescreen in a normal scenario.  This is a simulation of user behavior, so any Wait() type of calls won't really apply here much.

On a different note, I should have another test where the user immediately exits to homescreen right after triggering the app, because that is a different use case w.r.t. card view.  (it'll display an icon in the center)

Comment 5

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#oFTXY6ZuQAW9ZdY3iDKdQA

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 6

[Martijn Wargers (dead)]

(In reply to No-Jun Park [:njpark] from comment #4)
> In this instance, the sleep() is used to represent the amount of time a user
> spends after opening an app and decides to go back to the homescreen. It is
> reasonable to assume that user will wait at least the app is completely
> loaded, before decides to go back to the homescreen in a normal scenario. 
> This is a simulation of user behavior, so any Wait() type of calls won't
> really apply here much.

Afaik, this is not something that we do for Gaia UI tests at all. We generally try do the next action as soon as possible (and using time.sleep() as less as possible).

Autolander can't be trusted, atm, afaik, I think you should merge it yourself (provided Treeherder Try is green).

Comment 7

[No-Jun Park [:njpark]]

Manually merged since it does not affect gaia ui test at all

https://github.com/mozilla-b2g/gaia/commit/7414321345bfbd5347bd9d291fd0d10374db671f