Closed
Bug 1152548
Opened 9 years ago
Closed 8 years ago
fix obsolete -moz-background-origin and -moz-background-inline-policy in mail/themes/linux/mail/subscribe.css
Categories
(Thunderbird :: Theme, defect)
Tracking
(thunderbird45 fixed, thunderbird46 fixed)
RESOLVED
FIXED
Thunderbird 46.0
People
(Reporter: aceman, Assigned: Paenglab, Mentored)
Details
(Keywords: polish, Whiteboard: [good_first_bug])
Attachments
(1 file)
3.66 KB,
patch
|
mkmelin
:
review+
rkent
:
approval-comm-aurora+
|
Details | Diff | Splinter Review |
Opening File->Subscribe dialog in Thunderbird produces these warnings in console: Warning: Unknown property '-moz-background-origin'. Declaration dropped. Source File: chrome://messenger/skin/subscribe.css Line: 44, Column: 24 Source Code: -moz-background-origin: border; Warning: Unknown property '-moz-background-inline-policy'. Declaration dropped. Source File: chrome://messenger/skin/subscribe.css Line: 43, Column: 31 Source Code: -moz-background-inline-policy: continuous; Those seem to be the last remaining uses in c-c. They are in the file /mail/themes/linux/mail/subscribe.css These pages describe how to convert the rules into new syntax: https://developer.mozilla.org/en-US/docs/Web/CSS/background-origin https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-background-inline-policy
Comment 1•9 years ago
|
||
Would this be a good first bug for a new contributor? And would any of you like to mentor it? (If the answer to both those questions is "Yes!", you should ping mhoye who will likely publicize it to a wider audience… ;)
Comment 2•9 years ago
|
||
I'd be happy too, I'll ping mhoye in the morning.
Mentor: josiah
Whiteboard: [good_first_bug]
Comment 3•9 years ago
|
||
(In reply to Josiah Bruner [:JosiahOne] (needinfo for responses) from comment #2) > I'd be happy too, I'll ping mhoye in the morning.
Comment 4•9 years ago
|
||
(In reply to Josiah Bruner [:JosiahOne] (needinfo for responses) from comment #2) > I'd be happy too, I'll ping mhoye in the morning. I would like to work on this, how to approach ?
Assignee | ||
Comment 5•8 years ago
|
||
Magnus, you added this lines in bug 514829. Because of this I'm asking you for review. I don't see why we need this complicated construct and removed it with the same definitions we are using in folderPane.css.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8701454 -
Flags: review?(mkmelin+mozilla)
Comment 6•8 years ago
|
||
Comment on attachment 8701454 [details] [diff] [review] linuxSubscribe.patch Review of attachment 8701454 [details] [diff] [review]: ----------------------------------------------------------------- I don't recall but probably copied it from somewhere at the time. r=mkmelin
Attachment #8701454 -
Flags: review?(mkmelin+mozilla) → review+
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Comment 7•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/1bb352ac45e6 -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 46.0
Comment 8•8 years ago
|
||
Comment on attachment 8701454 [details] [diff] [review] linuxSubscribe.patch Should this be uplifted to 45?
Attachment #8701454 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 9•8 years ago
|
||
(In reply to Kent James (:rkent) from comment #8) > Comment on attachment 8701454 [details] [diff] [review] > linuxSubscribe.patch > > Should this be uplifted to 45? For removing the warnings, yes. It's a trivial fix which shouldn't harm anything.
Updated•8 years ago
|
Attachment #8701454 -
Flags: approval-comm-aurora? → approval-comm-aurora+
Comment 10•8 years ago
|
||
Aurora: https://hg.mozilla.org/releases/comm-aurora/rev/8b4d1da9517d
Updated•8 years ago
|
status-thunderbird45:
--- → fixed
status-thunderbird46:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•