1152548 - fix obsolete -moz-background-origin and -moz-background-inline-policy in mail/themes/linux/mail/subscribe.css

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[:aceman]

Opening File->Subscribe dialog in Thunderbird produces these warnings in console:

Warning: Unknown property '-moz-background-origin'.  Declaration dropped.
Source File: chrome://messenger/skin/subscribe.css
Line: 44, Column: 24
Source Code:
  -moz-background-origin: border;

Warning: Unknown property '-moz-background-inline-policy'.  Declaration dropped.
Source File: chrome://messenger/skin/subscribe.css
Line: 43, Column: 31
Source Code:
  -moz-background-inline-policy: continuous;

Those seem to be the last remaining uses in c-c. They are in the file
/mail/themes/linux/mail/subscribe.css

These pages describe how to convert the rules into new syntax:
https://developer.mozilla.org/en-US/docs/Web/CSS/background-origin
https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-background-inline-policy

Comment 1

[Blake Winton (:bwinton) (:☕️)]

Would this be a good first bug for a new contributor?  And would any of you like to mentor it?
(If the answer to both those questions is "Yes!", you should ping mhoye who will likely publicize it to a wider audience…  ;)

Comment 2

[Josiah Bruner [:jsbruner]]

I'd be happy too, I'll ping mhoye in the morning.

Comment 3

[Vishwas Jain]

(In reply to Josiah Bruner [:JosiahOne] (needinfo for responses) from comment #2)
> I'd be happy too, I'll ping mhoye in the morning.

Comment 4

[Vishwas Jain]

(In reply to Josiah Bruner [:JosiahOne] (needinfo for responses) from comment #2)
> I'd be happy too, I'll ping mhoye in the morning.

I would like to work on this, how to approach ?

Comment 5

[Richard Marti (:Paenglab)]

Attachment: linuxSubscribe.patch

Magnus, you added this lines in bug 514829. Because of this I'm asking you for review.

I don't see why we need this complicated construct and removed it with the same definitions we are using in folderPane.css.

Comment 6

[Magnus Melin [:mkmelin]]

Comment on attachment 8701454 [details] [diff] [review]
linuxSubscribe.patch

Review of attachment 8701454 [details] [diff] [review]:
-----------------------------------------------------------------

I don't recall but probably copied it from somewhere at the time. r=mkmelin

Comment 7

[Magnus Melin [:mkmelin]]

https://hg.mozilla.org/comm-central/rev/1bb352ac45e6 -> FIXED

Comment 8

[Kent James (:rkent)]

Comment on attachment 8701454 [details] [diff] [review]
linuxSubscribe.patch

Should this be uplifted to 45?

Comment 9

[Richard Marti (:Paenglab)]

(In reply to Kent James (:rkent) from comment #8)
> Comment on attachment 8701454 [details] [diff] [review]
> linuxSubscribe.patch
> 
> Should this be uplifted to 45?

For removing the warnings, yes. It's a trivial fix which shouldn't harm anything.

Comment 10

[Jorg K (CEST = GMT+2)]

Aurora:
https://hg.mozilla.org/releases/comm-aurora/rev/8b4d1da9517d