Closed
Bug 1152551
Opened 9 years ago
Closed 9 years ago
Fix mode lines in dom/
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: mccr8, Assigned: mccr8)
References
Details
Attachments
(4 files, 5 obsolete files)
26.31 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
12.87 KB,
text/plain
|
Details | |
1.21 MB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
15.95 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
See also bug 1151541. I'm going to skip dom/media for now because there's a lot of code in there, and a lot of it is imported. I have a script that semi-automatically does this fixup.
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
The script had a bug in the case where the MPL was in the same comment as the mode lines, with existing mode lines, and there was an empty line in between the mode line and the license. This version compiles for me locally.
Attachment #8589935 -
Attachment is obsolete: true
Assignee | ||
Comment 3•9 years ago
|
||
Oops, that was only for dom/base.
Attachment #8589965 -
Attachment is obsolete: true
Assignee | ||
Comment 4•9 years ago
|
||
Assignee | ||
Comment 5•9 years ago
|
||
I modified my script to find leading whitespace containing tabs. I manually fixed them. The diff -w is empty.
Attachment #8590359 -
Flags: review?(amarchesini)
Assignee | ||
Comment 6•9 years ago
|
||
Actually that didn't get the one in nsXMLContentSink.cpp. I also removed all trailing whitespace from that file. As before, diff -w for this patch is empty.
Attachment #8590363 -
Flags: review?(amarchesini)
Assignee | ||
Updated•9 years ago
|
Attachment #8590359 -
Attachment is obsolete: true
Attachment #8590359 -
Flags: review?(amarchesini)
Comment 7•9 years ago
|
||
Comment on attachment 8590363 [details] [diff] [review] part 1 - Remove leading tabs in dom/. Review of attachment 8590363 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for doing this.
Attachment #8590363 -
Flags: review?(amarchesini) → review+
Assignee | ||
Comment 8•9 years ago
|
||
I skipped a few directories. dom/media/* is huge, and includes a lot of imported code. dom/camera, dom/canvas, dom/system/qt/, dom/system/gonk/ and dom/system/gonk/android_audio/ had enough of a mix of imported code and maybe some 4 space indented code along with the 2 space indented code that I didn't want to deal with it. dom/plugins/*, dom/xslt/*, and dom/xul/* include a lot of old code that is 4 space indented, so we can't change the mode line to something for 2 space indentation. There's also a bunch of individual files I skipped because they were four space indented or whatever. You can look at the list fileBlackList in the script if you are curious.
Assignee | ||
Comment 9•9 years ago
|
||
Attachment #8589966 -
Attachment is obsolete: true
Attachment #8589982 -
Attachment is obsolete: true
Assignee | ||
Comment 10•9 years ago
|
||
jst volunteered to review this unreviewable patch. 1732 files changed, 3368 insertions(+), 2061 deletions(-) I flipped through the entire patch myself, so I don't think it mangles anything up too horribly. It also builds. The script is idempotent (if you run the script on dom/ twice the second pass makes no additional changes).
Attachment #8593648 -
Flags: review?(jst)
Comment 11•9 years ago
|
||
Comment on attachment 8593648 [details] [diff] [review] part 2 - Fix mode lines in dom/. Fun review indeed! ;) r=jst
Attachment #8593648 -
Flags: review?(jst) → review+
Assignee | ||
Comment 12•9 years ago
|
||
Some more fixes. Fairly small patch. Nothing surprising.
Attachment #8599878 -
Flags: review?(jst)
Updated•9 years ago
|
Attachment #8599878 -
Flags: review?(jst) → review+
Comment 13•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/1eceb802b81e https://hg.mozilla.org/integration/mozilla-inbound/rev/bd079aadd3fe https://hg.mozilla.org/integration/mozilla-inbound/rev/2ecdda58c673
Comment 14•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/1eceb802b81e https://hg.mozilla.org/mozilla-central/rev/bd079aadd3fe https://hg.mozilla.org/mozilla-central/rev/2ecdda58c673
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•