Closed Bug 1152556 Opened 5 years ago Closed 5 years ago

Set bug components in dom/media moz.build

Categories

(Core :: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: rillian, Assigned: rillian)

Details

Attachments

(3 files, 1 obsolete file)

We should set bugzilla components for some of our areas in the respective moz.build files, per bug 1132771.
Per https://bugzilla.mozilla.org/show_bug.cgi?id=1139087#c4 we don't need build peer approval for these changes.
Attachment #8589913 - Flags: review?(kinetik)
Attachment #8589915 - Flags: review?(adam)
Attachment #8589913 - Flags: review?(kinetik) → review+
Summary: Set bug componets in dom/media moz.build → Set bug components in dom/media moz.build
Comment on attachment 8589915 [details] [diff] [review]
Set bug components for dom/media/webrtc

Review of attachment 8589915 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately, the division of components here isn't terribly clean, so this patch is only *mostly* correct. Specifically, under dom/media/webrtc, the files PeerIdentity.cpp and PeerIdentity.h should be part of "Core :: WebRTC: Signaling".

In a similar way, under dom/media, the files IdpSandbox.jsm, PeerConnection.js, PeerConnection.manifest, PeerConnectionIdp.jsm, RTCIdentityProviderRegistrar.cpp, RTCStatsReport.jsm, and RTCIdentityProviderRegistrar.h should also be part of "Core :: WebRTC: Signaling".

And (again in dom/media), GetUserMediaRequest.cpp and GetUserMediaRequest.h should be part of "Core :: WebRTC: Audio/Video".

This isn't awesome, and I have a module governance proposal that I'll be making very soon that would reorganize at least the WebRTC Signaling files in a way that aligns the directory structure more closely with the Bugzilla components.
Attachment #8589915 - Flags: review?(adam) → feedback+
Thanks for the pointers. I've added the file-specific overrides.
Attachment #8589915 - Attachment is obsolete: true
Attachment #8591156 - Flags: review?(adam)
Comment on attachment 8591156 [details] [diff] [review]
Set bug components for dom/media/webrtc v2

Review of attachment 8591156 [details] [diff] [review]:
-----------------------------------------------------------------

The assignments here seem correct now.
Comment on attachment 8591156 [details] [diff] [review]
Set bug components for dom/media/webrtc v2

Review of attachment 8591156 [details] [diff] [review]:
-----------------------------------------------------------------

Once more, with feeling.
Attachment #8591156 - Flags: review?(adam) → review+
Comment on attachment 8589914 [details] [diff] [review]
Set bug components for dom/media/webaudio

Karl won't be back for a few more days. Paul, can you review this? Very quick.
Attachment #8589914 - Flags: review?(karlt) → review?(padenot)
Comment on attachment 8589914 [details] [diff] [review]
Set bug components for dom/media/webaudio

Review of attachment 8589914 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8589914 - Flags: review?(padenot) → review+
You need to log in before you can comment on or make changes to this bug.