1152556 - Set bug components in dom/media moz.build

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Ralph Giles (:rillian)]

We should set bugzilla components for some of our areas in the respective moz.build files, per bug 1132771.

Comment 1

[Ralph Giles (:rillian)]

Attachment: Set bug components for dom/media and dom/media/recording

Per https://bugzilla.mozilla.org/show_bug.cgi?id=1139087#c4 we don't need build peer approval for these changes.

Comment 2

[Ralph Giles (:rillian)]

Attachment: Set bug components for dom/media/webaudio

Comment 3

[Ralph Giles (:rillian)]

Attachment: Set bug components for dom/media/webrtc

Comment 4

[Adam Roach [:abr]]

Comment on attachment 8589915 [details] [diff] [review]
Set bug components for dom/media/webrtc

Review of attachment 8589915 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately, the division of components here isn't terribly clean, so this patch is only *mostly* correct. Specifically, under dom/media/webrtc, the files PeerIdentity.cpp and PeerIdentity.h should be part of "Core :: WebRTC: Signaling".

In a similar way, under dom/media, the files IdpSandbox.jsm, PeerConnection.js, PeerConnection.manifest, PeerConnectionIdp.jsm, RTCIdentityProviderRegistrar.cpp, RTCStatsReport.jsm, and RTCIdentityProviderRegistrar.h should also be part of "Core :: WebRTC: Signaling".

And (again in dom/media), GetUserMediaRequest.cpp and GetUserMediaRequest.h should be part of "Core :: WebRTC: Audio/Video".

This isn't awesome, and I have a module governance proposal that I'll be making very soon that would reorganize at least the WebRTC Signaling files in a way that aligns the directory structure more closely with the Bugzilla components.

Comment 5

[Ralph Giles (:rillian)]

Attachment: Set bug components for dom/media/webrtc v2

Thanks for the pointers. I've added the file-specific overrides.

Comment 6

[Adam Roach [:abr]]

Comment on attachment 8591156 [details] [diff] [review]
Set bug components for dom/media/webrtc v2

Review of attachment 8591156 [details] [diff] [review]:
-----------------------------------------------------------------

The assignments here seem correct now.

Comment 7

[Adam Roach [:abr]]

Comment on attachment 8591156 [details] [diff] [review]
Set bug components for dom/media/webrtc v2

Review of attachment 8591156 [details] [diff] [review]:
-----------------------------------------------------------------

Once more, with feeling.

Comment 8

[Ralph Giles (:rillian)]

Comment on attachment 8589914 [details] [diff] [review]
Set bug components for dom/media/webaudio

Karl won't be back for a few more days. Paul, can you review this? Very quick.

Comment 9

[Paul Adenot (:padenot)]

Comment on attachment 8589914 [details] [diff] [review]
Set bug components for dom/media/webaudio

Review of attachment 8589914 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 10

[Ralph Giles (:rillian)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9b07a8f2c307
https://hg.mozilla.org/integration/mozilla-inbound/rev/e994b757c6ae
https://hg.mozilla.org/integration/mozilla-inbound/rev/d6e5a6db330c

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9b07a8f2c307
https://hg.mozilla.org/mozilla-central/rev/e994b757c6ae
https://hg.mozilla.org/mozilla-central/rev/d6e5a6db330c