Closed
Bug 1152573
Opened 9 years ago
Closed 9 years ago
Animation of the nav menu is not very smooth
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
2015-04-21
People
(Reporter: krupa.mozbugs, Assigned: mstriemer)
References
Details
Attachments
(1 file)
1.21 MB,
video/quicktime
|
Details |
Connectivity: wifi Gaia/device: flame/3.0 steps to reproduce: 1. Launch marketplace-dev and enable the new nav 2. Click on the hamburger menu icon 3. Switch to Popular tab 4. See the animation expected behavior: The switch to Popular page is smooth actual behavior: The animation of the navigation menu is clunky and is not smooth. See video.
Assignee | ||
Comment 1•9 years ago
|
||
I don't see this on my flame (I don't see any animation) but I see something similar on my Nexus 5. The content and the header don't animate together and get out of sync.
Updated•9 years ago
|
Priority: -- → P1
Target Milestone: --- → 2015-04-21
Updated•9 years ago
|
Assignee: nobody → kngo
Assignee | ||
Comment 2•9 years ago
|
||
Seems like we could probably put the transiton on `main` since that should be the only other element visible at mobile widths. That should get everything to slide together.
Comment 3•9 years ago
|
||
Flame 2.x shows no animation. Flame 3.0 is smooth. Nexus 7 is choppy, but at least they seem to intend to animate together. Desktop browsers are smooth.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 4•9 years ago
|
||
Nevermind, it flame 3.0 wasn't super smooth. Not sure what to do for this atm without reworking how the mobile nav is exposed.
Assignee: kngo → nobody
Comment 5•9 years ago
|
||
My idea is to set a .stopPropagation() on all clicks to `mkt-nav a`, then set a timeout for ~300ms to allow time for the Nav to close. The issue seemed to be trying to render a page and animate it at the same time, causing the `header` to go faster than `main`. I can work on this Monday.
Assignee: nobody → kngo
Updated•9 years ago
|
Assignee: kngo → mstriemer
Updated•9 years ago
|
Severity: normal → blocker
Assignee | ||
Comment 6•9 years ago
|
||
https://github.com/mozilla/fireplace/commit/7d956905f860d2f7994b607060b3ba98c81b43cd
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•