All users were logged out of Bugzilla on October 13th, 2018
I don't think this ever made its way to the new perf tool somehow. http://i.imgur.com/bxApr2M.png
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Created attachment 8605995 [details] [diff] [review] categorie-fail.patch
Attachment #8605995 - Flags: review?(jsantell)
Comment on attachment 8605995 [details] [diff] [review] categorie-fail.patch Review of attachment 8605995 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/performance/test/browser.ini @@ +14,5 @@ > [browser_markers-gc.js] > [browser_markers-parse-html.js] > [browser_markers-timestamp.js] > [browser_perf-allocations-to-samples.js] > +[browser_perf-categories-js-calltree.js] Probably should just be in browser_perf-details-js-call-tree-02 or something yeah? No need to have a full test suite for it ::: browser/devtools/performance/views/details-js-call-tree.js @@ +123,5 @@ > root.attachTo(this.container); > > // When platform data isn't shown, hide the cateogry labels, since they're > + // only available for C++ frames. Pass *false* to make them invisible. > + root.toggleCategories(!options.contentOnly); wow
Attachment #8605995 - Flags: review?(jsantell) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox41: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 41
Comment on attachment 8605995 [details] [diff] [review] categorie-fail.patch Approval Request Comment [Feature/regressing bug #]: 1167252, the new performance tool [User impact if declined]: Won't ship the performance tool [Describe test coverage new/current, TreeHerder]: There are try pushes in Bug 1167252 with all patches needing uplift [Risks and why]: Requesting uplift for the accumulated changes in the performance tool since the 40 merge date, so these changes haven't had the full 6 weeks to bake. Risks are generally contained within devtools, specifically within the performance panel. [String/UUID change made/needed]: None
Attachment #8605995 - Flags: approval-mozilla-aurora?
status-firefox40: --- → fixed
Note: I had verbal confirmation for these uplifts from Sylvestre even before he's flagged them as a+. See https://bugzilla.mozilla.org/show_bug.cgi?id=1167252#c26
Comment on attachment 8605995 [details] [diff] [review] categorie-fail.patch Change approved to skip one train as part of the spring campaign.
Attachment #8605995 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Verified fixed on Aurora 40.0a2 (2015-06-04), using Ubuntu 14.04 (x64), Windows 7 (x64) and Mac OS X 10.9.5. Categories are now displayed for most of the data available in the Call Tree, including Gecko Platform Data.
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
You need to log in before you can comment on or make changes to this bug.