Open Bug 1152634 Opened 9 years ago Updated 2 years ago

Use a new build define instead of re-purposing MOZ_UPDATER

Categories

(Firefox Build System :: Android Studio and Gradle Integration, defect)

Product:
Firefox Build System
Component:
Android Studio and Gradle Integration
Platform:
All
Android
Type:
defect

Tracking

(Not tracked)

Status:
REOPENED

People

(Reporter: robert.strong.bugs, Unassigned)

Details

This has caused problems in the past for Android builds (see bug 1031874) since the define is specifically for the application update component and should not be re-purposed for other uses.
Note: I cleaned up the build system from the toolkit end of things in bug 1152997. When this bug is fixed |#if defined(MOZ_UPDATER) && !defined(MOZ_WIDGET_ANDROID)| etc. that was added in bug 1152997 can be changed to just |if defined(MOZ_UPDATER)| etc.
What usage I see in mobile/ now looks appropriate: https://searchfox.org/mozilla-central/search?q=MOZ_UPDATER&path=mobile.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
This has caused breakage when landing in the past as well as compiling code not used by mobile because it has two different meanings in common code due to the re-purposing by mobile. One example
https://dxr.mozilla.org/mozilla-central/source/toolkit/xre/nsAppRunner.cpp#27
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #3)
> This has caused breakage when landing in the past as well as compiling code
> not used by mobile because it has two different meanings in common code due
> to the re-purposing by mobile. One example
> https://dxr.mozilla.org/mozilla-central/source/toolkit/xre/nsAppRunner.cpp#27

Thanks for the clarification, Robert.  I saw no shady uses in mobile/ but I see now what you mean.
Product: Firefox for Android → Firefox Build System
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.