Closed
Bug 1152638
Opened 9 years ago
Closed 9 years ago
[Stingray] Rename all _test folder as test under tv_apps/
Categories
(Firefox OS Graveyard :: Gaia::TV, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dwi2, Assigned: dwi2)
References
Details
Attachments
(1 file)
This is precondition for enabling unit test of TV apps. 1. Rename all _test folder as test under tv_apps/ 2. Fix all these unit tests.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Comment on attachment 8590047 [details] [review] [gaia] dwi2:bug1152638 > mozilla-b2g:master Hi John, Rex, Please help to review the patch. This patch rename all '_test' folder to 'test', and fix interactive_notification_test.js in smart-system. When we done moving tv_apps/ to apps/ in bug 1142372, all these unit tests will be enabled by default.
Attachment #8590047 -
Flags: review?(rexboy)
Attachment #8590047 -
Flags: review?(im)
Comment 3•9 years ago
|
||
Comment on attachment 8590047 [details] [review] [gaia] dwi2:bug1152638 > mozilla-b2g:master Looks good to me. Thanks for enabling unit-tests in TV.
Attachment #8590047 -
Flags: review?(im) → review+
Comment 4•9 years ago
|
||
Comment on attachment 8590047 [details] [review] [gaia] dwi2:bug1152638 > mozilla-b2g:master Looks good to me on the card_manager part. Maybe someday we can move test of card_manager to some shared place if possible.
Attachment #8590047 -
Flags: review?(rexboy) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 5•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/238a425a80c5a6a6a7967ed7cc45a91bbd1508b2
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick]
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick]
You need to log in
before you can comment on or make changes to this bug.
Description
•