Closed Bug 1152666 Opened 5 years ago Closed 5 years ago

[System] JSHint for group 3: telephony related

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: johnhu, Assigned: johnhu)

References

Details

Attachments

(1 file)

files:

apps/system/js/emergency_callback_manager.js
apps/system/js/icc_events.js
apps/system/js/sim_lock.js

If they have test case, please fix them at the same time.
Assignee: nobody → im
Comment on attachment 8590111 [details] [review]
[gaia] huchengtw-moz:bug-1152666-jshint-telephony > mozilla-b2g:master

This patch fixes jshint errors/warnings for telephony related files. Please review this patch. Thanks.
Attachment #8590111 - Flags: review?(alive)
Comment on attachment 8590111 [details] [review]
[gaia] huchengtw-moz:bug-1152666-jshint-telephony > mozilla-b2g:master

remove review flag because of test cases failed.
Attachment #8590111 - Flags: review?(alive)
Comment on attachment 8590111 [details] [review]
[gaia] huchengtw-moz:bug-1152666-jshint-telephony > mozilla-b2g:master

This patch fixes jshint errors/warnings. Please review this patch.
Attachment #8590111 - Flags: review?(alive)
Attachment #8590111 - Flags: review?(alive) → review?(gduan)
Comment on attachment 8590111 [details] [review]
[gaia] huchengtw-moz:bug-1152666-jshint-telephony > mozilla-b2g:master

r=gduan
Attachment #8590111 - Flags: review?(gduan) → review+
You need to log in before you can comment on or make changes to this bug.