1152666 - [System] JSHint for group 3: telephony related

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

files:

apps/system/js/emergency_callback_manager.js
apps/system/js/icc_events.js
apps/system/js/sim_lock.js

If they have test case, please fix them at the same time.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] huchengtw-moz:bug-1152666-jshint-telephony > mozilla-b2g:master

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8590111 [details] [review]
[gaia] huchengtw-moz:bug-1152666-jshint-telephony > mozilla-b2g:master

This patch fixes jshint errors/warnings for telephony related files. Please review this patch. Thanks.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8590111 [details] [review]
[gaia] huchengtw-moz:bug-1152666-jshint-telephony > mozilla-b2g:master

remove review flag because of test cases failed.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8590111 [details] [review]
[gaia] huchengtw-moz:bug-1152666-jshint-telephony > mozilla-b2g:master

This patch fixes jshint errors/warnings. Please review this patch.

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8590111 [details] [review]
[gaia] huchengtw-moz:bug-1152666-jshint-telephony > mozilla-b2g:master

r=gduan

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/68bc942912c5da7974c8220e8824355db3848d9c

tree herder is all green:
https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=eba2233d73780903bb8549796f3a47209fa37cda