Closed Bug 1152678 Opened 5 years ago Closed 4 years ago

Move Lightning preference pane to the left of Advanced

Categories

(Calendar :: Preferences, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nONoNonO, Assigned: nONoNonO)

Details

Attachments

(1 file)

At the moment the last pane in Tools -> Options is the Lightning pane.
It would be better to move the Lightning pane to the left, at least in front of the Advanced options pane, so that Advanced is always the last pane, either with or without calendar...
Attachment #8720159 - Flags: ui-review?
Attachment #8720159 - Flags: review?(philipp)
Assignee: nobody → o.e.ekker
Status: NEW → ASSIGNED
Comment on attachment 8720159 [details] [diff] [review]
paneLightning.patch

Review of attachment 8720159 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, thanks for the patch and sorry for the delay. Given this changes the order for a dialog primary to Thunderbird I'd like some feedback from Magnus as well.
Attachment #8720159 - Flags: ui-review?
Attachment #8720159 - Flags: ui-review+
Attachment #8720159 - Flags: review?(philipp)
Attachment #8720159 - Flags: review+
Attachment #8720159 - Flags: feedback?(mkmelin+mozilla)
Comment on attachment 8720159 [details] [diff] [review]
paneLightning.patch

Review of attachment 8720159 [details] [diff] [review]:
-----------------------------------------------------------------

I like it!
Attachment #8720159 - Flags: feedback?(mkmelin+mozilla) → feedback+
Cool, then the next step is to check in, right?
Keywords: checkin-needed
http://hg.mozilla.org/comm-central/rev/bdb9854f10bf

Is this something we want in ESR?
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 5.0
Attachment #8720159 - Flags: approval-calendar-release?(philipp)
Attachment #8720159 - Flags: approval-calendar-beta?(philipp)
Attachment #8720159 - Flags: approval-calendar-aurora?(philipp)
Comment on attachment 8720159 [details] [diff] [review]
paneLightning.patch

Review of attachment 8720159 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think it is necessary to backport this to ESR. While it is just a minor change and unlikely to break anything, it is not a critical issue.
Attachment #8720159 - Flags: approval-calendar-release?(philipp)
Attachment #8720159 - Flags: approval-calendar-release-
Attachment #8720159 - Flags: approval-calendar-beta?(philipp)
Attachment #8720159 - Flags: approval-calendar-beta-
Attachment #8720159 - Flags: approval-calendar-aurora?(philipp)
Attachment #8720159 - Flags: approval-calendar-aurora-
You need to log in before you can comment on or make changes to this bug.