Closed Bug 1152710 Opened 6 years ago Closed 6 years ago

[System] JSHint for unit tests: entrysheet, iac_handler, keyboard, lockscreen, mobile operator, orientation, settings, wifi

Categories

(Firefox OS Graveyard :: Gaia, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: johnhu, Assigned: chens)

References

Details

Attachments

(1 file)

files:

apps/system/test/unit/entery_sheet_test.js
apps/system/test/unit/iac_handler_test.js
apps/system/test/unit/keyboard_helper_test.js
apps/system/test/unit/lockscreen/lockscreen_test.js
apps/system/test/unit/mobile_operator_test.js
apps/system/test/unit/orientation_manager_test.js
apps/system/test/unit/settings_helper_test.js
apps/system/test/unit/wifi_test.js
We will not change these two files until next phase, could change in bug 1094759:

apps/system/test/unit/orientation_manager_test.js
apps/system/test/unit/wifi_test.js
Assignee: nobody → chens
Comment on attachment 8590599 [details] [review]
[gaia] shamenchens:Bug1152710-JshintEntrySheet > mozilla-b2g:master

Alive, this patch fixes jshint error in unit tests, would you review it? thanks!
Greg, could you help to review lockscreen unit test changes in this patch?
Attachment #8590599 - Flags: review?(gweng)
Attachment #8590599 - Flags: review?(alive)
Attachment #8590599 - Flags: review?(gweng) → review+
Comment on attachment 8590599 [details] [review]
[gaia] shamenchens:Bug1152710-JshintEntrySheet > mozilla-b2g:master

Rudy, this patch also fix jshint error in keyboard helper, would you review changes in keyboard? thanks!
Attachment #8590599 - Flags: review?(rlu)
Comment on attachment 8590599 [details] [review]
[gaia] shamenchens:Bug1152710-JshintEntrySheet > mozilla-b2g:master

r+ for keyboard_helper part, thanks.
Attachment #8590599 - Flags: review?(rlu) → review+
Attachment #8590599 - Flags: review?(alive) → review?(gduan)
Comment on attachment 8590599 [details] [review]
[gaia] shamenchens:Bug1152710-JshintEntrySheet > mozilla-b2g:master

r+ for system related part.
Attachment #8590599 - Flags: review?(gduan) → review+
master: https://github.com/mozilla-b2g/gaia/commit/a227a71e8063812623acd411a365ab90416e51d4
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.