1152710 - [System] JSHint for unit tests: entrysheet, iac_handler, keyboard, lockscreen, mobile operator, orientation, settings, wifi

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

files:

apps/system/test/unit/entery_sheet_test.js
apps/system/test/unit/iac_handler_test.js
apps/system/test/unit/keyboard_helper_test.js
apps/system/test/unit/lockscreen/lockscreen_test.js
apps/system/test/unit/mobile_operator_test.js
apps/system/test/unit/orientation_manager_test.js
apps/system/test/unit/settings_helper_test.js
apps/system/test/unit/wifi_test.js

Comment 1

[Sherman Chen [:chens] (inactive)]

We will not change these two files until next phase, could change in bug 1094759:

apps/system/test/unit/orientation_manager_test.js
apps/system/test/unit/wifi_test.js

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] shamenchens:Bug1152710-JshintEntrySheet > mozilla-b2g:master

Comment 3

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8590599 [details] [review]
[gaia] shamenchens:Bug1152710-JshintEntrySheet > mozilla-b2g:master

Alive, this patch fixes jshint error in unit tests, would you review it? thanks!
Greg, could you help to review lockscreen unit test changes in this patch?

Comment 4

[Sherman Chen [:chens] (inactive)]

Comment on attachment 8590599 [details] [review]
[gaia] shamenchens:Bug1152710-JshintEntrySheet > mozilla-b2g:master

Rudy, this patch also fix jshint error in keyboard helper, would you review changes in keyboard? thanks!

Comment 5

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8590599 [details] [review]
[gaia] shamenchens:Bug1152710-JshintEntrySheet > mozilla-b2g:master

r+ for keyboard_helper part, thanks.

Comment 6

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8590599 [details] [review]
[gaia] shamenchens:Bug1152710-JshintEntrySheet > mozilla-b2g:master

r+ for system related part.

Comment 7

[Sherman Chen [:chens] (inactive)]

master: https://github.com/mozilla-b2g/gaia/commit/a227a71e8063812623acd411a365ab90416e51d4