1152737 - [MCTS][2.2] webapi:telephony test cause Telephony.oncallschanged event not found

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Certification Suite, defect)

Description

[oo[oouyang]]

From the following bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1081811

We think it need makes some change depends on this bug.

Comment 1

[oo[oouyang]]

Hi Hsin-Yi,

I think this case is related to bug 1081811.
Could you give us some hint or infomration, and let us to modify this case to resolve this issue?

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to oo[oouyang] from comment #1)
> Hi Hsin-Yi,
> 
> I think this case is related to bug 1081811.
> Could you give us some hint or infomration, and let us to modify this case
> to resolve this issue?

Sure.

After bug 1081811, please make sure that you don't rely on 'callschanged' event to determine if telephony initialization work completes. You should wait for 'ready' event instead. Please give it a try and see if my suggestion helps.

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #2)
> (In reply to oo[oouyang] from comment #1)
> > Hi Hsin-Yi,
> > 
> > I think this case is related to bug 1081811.
> > Could you give us some hint or infomration, and let us to modify this case
> > to resolve this issue?
> 
> Sure.
> 
> After bug 1081811, please make sure that you don't rely on 'callschanged'
> event to determine if telephony initialization work completes. You should
> wait for 'ready' event instead. Please give it a try and see if my
> suggestion helps.

Sorry, there's no ready event in the latest m-c code. Instead, we have a 'ready' promise.

Comment 4

[oo[oouyang]]

Hi Hsin-yi,

Could you please provide a piece of sample code to use 'ready' promise?

Thanks

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Do something like:
 
let telephony = window.navigator.mozTelephony;

telephony.ready.then(
  function() {
    // Do what you need once telephony is ready.  
    console.log("Telephony got ready");

   // Some callback here...
  },
  function() {
   // Do what you need once telephony fails initializing.
  }
);


gecko/dom/telephony/test/marionette/test_ready.js could also provide a good reference to you.

Comment 6

[oo[oouyang]]

Attachment: fix telephony 2.2 issues

Comment 7

[Askeing Yen[:askeing][:fyen]]

Comment on attachment 8591485 [details] [review]
fix telephony 2.2 issues

LGTM

Comment 8

[Al Tsai [:atsai]]

Comment on attachment 8591485 [details] [review]
fix telephony 2.2 issues

r=me. merged.