1152759 - Regroup Performance Monitoring code

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, defect)

Description

[David Teller [:Yoric] - still alive but not very active]

We have performance monitoring code in toolkit/modules and toolkit/components/aboutperformance. Let's regroup it in toolkit/components/perfmonitoring.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: Regrouping code in toolkit/components/perfmonitoring

Just moving files around.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ffb558504fe7

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: Regrouping code in toolkit/components/perfmonitoring, v2

Ah, forgot to update a url.
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=73b045549789

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Attachment: Regrouping code in toolkit/components/perfmonitoring, v3

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f4aa2eb8ee2

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Attachment: Recapitulating alerts in about:performance, v4

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b8b2cf3df985

Comment 5

[David Teller [:Yoric] - still alive but not very active]

Attachment: Regrouping code in toolkit/components/perfmonitoring, v4

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d11b9817fabd

Comment 6

[Carsten Book [:Tomcat]]

Hi David,
this failed to apply:

adding 1152759 to series file
renamed 1152759 -> export.diff
applying export.diff
patching file toolkit/modules/moz.build
Hunk #1 FAILED at 6
1 out of 2 hunks FAILED -- saving rejects to file toolkit/modules/moz.build.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh export.diff

could you take a look, thanks!

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Attachment: Regrouping code in toolkit/components/perfmonitoring, v5

Rebased.

Comment 8

[David Teller [:Yoric] - still alive but not very active]

Something's weird. Taking another look before I mark this checkin-needed.

Comment 9

[David Teller [:Yoric] - still alive but not very active]

Attachment: Regrouping code in toolkit/components/perfmonitoring, v6

Not quite sure why this passed Try without that change.
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3613196f73cb

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/023961de7f2f

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/fx-team/rev/023961de7f2f

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/023961de7f2f

Comment 13

[David Teller [:Yoric] - still alive but not very active]

Attachment: MozReview Request: bz://1152759/Yoric

/r/7311 - Bug 1152759 - Regroup Performance Monitoring modules/components;r=yoric
/r/7317 - Bug 1154239 - Rework PerformanceStats.jsm for modularity and asynchronicity;r=Mossop

Pull down these commits:

hg pull -r 97d4a1e4700a215c48fb3c9f40e39a255e0672a9 https://reviewboard-hg.mozilla.org/gecko/