Log parsing errors should include the name of the project and log URL

RESOLVED FIXED

Status

Tree Management
Treeherder: Data Ingestion
P2
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: emorley, Assigned: emorley, Mentored)

Tracking

Details

(Whiteboard: [good first bug][lang=python])

User Story

Thank you for helping out with Treeherder!

You can find us on IRC at irc://irc.mozilla.org/treeherder

Here's some links to help get you started.

Project page:
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder

Repo locations and links to set up a development version of the software:
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Getting_Started

Interacting with us:
https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Contributing

A-Team general reference, coding style guides:
http://ateam-bootcamp.readthedocs.org

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Errors like:
[2015-04-09 05:56:42,217: ERROR/Worker-6] Failed to download and/or parse artifact for guid '8a94426d-63d7-48aa-a0b5-d3d14af4c9d9/0': HTTP Error 404: Not Found

Are not very actionable, since I can't look up the job without knowing which project it belongs to, unless I want to query every database.

In addition, if we listed the log URL itself it would ave me having to actually query the DB at all.
(Assignee)

Updated

3 years ago
Blocks: 1152742
This should be trivial, just update the log message to include the url which we reference just above.

https://github.com/mozilla/treeherder-service/blob/master/treeherder/log_parser/utils.py#L279

I'm going to mark this as a good first bug but please don't let that stop you from just fixing this if you want to. :)
Mentor: wlachance@mozilla.com
User Story: (updated)
Whiteboard: [good first bug][lang=python]
(note that although this bug is simple to fix, actually verifying your change does involve setting up an instance of treeherder-service which can be fairly time consuming)
(Assignee)

Comment 3

3 years ago
I have a branch for this locally already, since it's needed for bug 1152742 (and meant debugging the tree closure this morning took longer) - sorry meant to assign the bug to me from the outset :-)
Assignee: nobody → emorley
Status: NEW → ASSIGNED
(Assignee)

Comment 4

3 years ago
Created attachment 8590287 [details] [review]
Log parser: Make error & debug output strings more useful

:-)
Attachment #8590287 - Flags: review?(wlachance)
Comment on attachment 8590287 [details] [review]
Log parser: Make error & debug output strings more useful

looks great, thanks!
Attachment #8590287 - Flags: review?(wlachance) → review+

Comment 6

3 years ago
Commit pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/cc0508b6f32a4ae81d0fcd9acc323e1df2637745
Bug 1152769 - Log parser: Make error & debug output strings more useful

In order to find the job in question, the project name is required in
addition to the job guid. We also now specify the URL for errors, to
save having to look up the job at all in many cases.
(Assignee)

Comment 7

3 years ago
Thanks :-)
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.