Closed Bug 1152769 Opened 7 years ago Closed 7 years ago
Log parsing errors should include the name of the project and log URL
Thank you for helping out with Treeherder! You can find us on IRC at irc://irc.mozilla.org/treeherder Here's some links to help get you started. Project page: https://wiki.mozilla.org/Auto-tools/Projects/Treeherder Repo locations and links to set up a development version of the software: https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Getting_Started Interacting with us: https://wiki.mozilla.org/Auto-tools/Projects/Treeherder#Contributing A-Team general reference, coding style guides: http://ateam-bootcamp.readthedocs.org
54 bytes, text/x-github-pull-request
|Details | Review|
Errors like: [2015-04-09 05:56:42,217: ERROR/Worker-6] Failed to download and/or parse artifact for guid '8a94426d-63d7-48aa-a0b5-d3d14af4c9d9/0': HTTP Error 404: Not Found Are not very actionable, since I can't look up the job without knowing which project it belongs to, unless I want to query every database. In addition, if we listed the log URL itself it would ave me having to actually query the DB at all.
This should be trivial, just update the log message to include the url which we reference just above. https://github.com/mozilla/treeherder-service/blob/master/treeherder/log_parser/utils.py#L279 I'm going to mark this as a good first bug but please don't let that stop you from just fixing this if you want to. :)
User Story: (updated)
Whiteboard: [good first bug][lang=python]
(note that although this bug is simple to fix, actually verifying your change does involve setting up an instance of treeherder-service which can be fairly time consuming)
I have a branch for this locally already, since it's needed for bug 1152742 (and meant debugging the tree closure this morning took longer) - sorry meant to assign the bug to me from the outset :-)
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Attachment #8590287 - Flags: review?(wlachance)
Comment on attachment 8590287 [details] [review] Log parser: Make error & debug output strings more useful looks great, thanks!
Attachment #8590287 - Flags: review?(wlachance) → review+
Commit pushed to master at https://github.com/mozilla/treeherder-service https://github.com/mozilla/treeherder-service/commit/cc0508b6f32a4ae81d0fcd9acc323e1df2637745 Bug 1152769 - Log parser: Make error & debug output strings more useful In order to find the job in question, the project name is required in addition to the job guid. We also now specify the URL for errors, to save having to look up the job at all in many cases.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.