bugzilla.mozilla.org has resumed normal operation. Attachments prior to 2014 will be unavailable for a few days. This is tracked in Bug 1475801.
Please report any other irregularities here.

Investigate perma-orange crash on browser_pluginCrashReportNonDeterminism.js and re-enable

RESOLVED FIXED in Firefox 58

Status

()

Core
Plug-ins
P2
normal
RESOLVED FIXED
3 years ago
8 months ago

People

(Reporter: mconley, Assigned: gsvelto)

Tracking

(Blocks: 1 bug, {crash})

unspecified
mozilla59
x86
Linux
crash
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(e10s+, firefox-esr52 wontfix, firefox57 wontfix, firefox58 fixed, firefox59 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

Bug 1110887 introduced a new test to exercise our handling of some non-determinism with how the content and browser processes handle plugin process crashes.

That test seems to fail consistently on Linux when run in the suite. It seems that we hit a content process crash due to a MOZ_ABORT:

[Parent 22296] WARNING: '!aObserver', file /media/Projects/mozilla/mozilla-central/xpcom/ds/nsObserverService.cpp, line 287
[Child 22926] ###!!! ABORT: X_CreateGC: BadDrawable (invalid Pixmap or Window parameter); sync; id=0x4400008: file /media/Projects/mozilla/mozilla-central/toolkit/xre/nsX11ErrorHandler.cpp, line 157
#01: X11Error (/media/Projects/mozilla/mozilla-central/toolkit/xre/nsX11ErrorHandler.cpp:158)
[Child 22926] ###!!! ABORT: X_CreateGC: BadDrawable (invalid Pixmap or Window parameter); sync; id=0x4400008: file /media/Projects/mozilla/mozilla-central/toolkit/xre/nsX11ErrorHandler.cpp, line 157
Hit MOZ_CRASH() at /media/Projects/mozilla/mozilla-central/memory/mozalloc/mozalloc_abort.cpp:33

And here's a screenshot at the time of failure:

http://i.imgur.com/Tf7xbfb.png

I can reproduce this locally by running the test on a debug build with --run-until-failure. It only takes two or three repeats for the failure to rear its head.

We should figure out what's going on and re-enable the test.
Blocks: 984139
tracking-e10s: --- → +

Comment 1

3 years ago
Let's start this off where the test lives, and if the issue is in another component we can always move it.
Component: General → Plug-ins
Product: Firefox → Core
Keywords: crash
Priority: -- → P2
I'm looking into this. I've run the tests locally together with other ones and it seems to be working again so maybe it's time to re-enable it.
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
(Reporter)

Comment 5

8 months ago
mozreview-review
Comment on attachment 8929181 [details]
Bug 1152811 - Re-enable browser_pluginCrashReportNonDeterminism.js;

https://reviewboard.mozilla.org/r/200476/#review205612

Thanks!
Attachment #8929181 - Flags: review?(mconley) → review+

Comment 6

8 months ago
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/30022d08636e
Re-enable browser_pluginCrashReportNonDeterminism.js; r=mconley

Comment 7

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/30022d08636e
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Might as well land this on Beta too, I reckon.
status-firefox57: --- → wontfix
status-firefox58: --- → affected
status-firefox-esr52: --- → wontfix
Whiteboard: [checkin-needed-beta]

Comment 9

8 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/0d20053d0805
status-firefox58: affected → fixed
Flags: in-testsuite+
Whiteboard: [checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.