1152816 - Add Firefox on iOS to AAQ

Status: RESOLVED FIXED

(support.mozilla.org :: Questions, task, P2)

Description

[Kadir Topal [:atopal]]

We need to add the product Firefox for iOS to the AAQ

Comment 1

[Michael Cooper [:mythmon]]

This should be pretty simple. 1pt.

Comment 2

[madalina]

Added to champion backlog

Comment 3

[Kadir Topal [:atopal]]

Rehan, we have the icon in bug 1152830

Comment 4

[Michael Cooper [:mythmon]]

The code for this is ready and reviewed in a PR here: https://github.com/mozilla/kitsune/pull/2490

However, once we merge and deploy that code, iOS will show up in the AAQ. It isn't like the KB where we can toggle it on and off in the admin.

So for now we have code ready, but can't proceed until we get the go ahead.

Comment 5

[Kadir Topal [:atopal]]

Mike, in the admin we can choose the locale and product combinations that should be activated for the AAQ flow. I tried that with English, but it doesn't seem to have an effect (I tried adding Firefox for iOS and removing Firefox for Android). So, I'm assuming English is a special case and the admin setting is only for other locales?

If that's the case, once this lands on production, we'd still have to change the settings in the admin to specify which locale would get the Firefox for iOS forums, right?

Comment 6

[Michael Cooper [:mythmon]]

The page in the AAQ that asks which product you want to use has a hard coded list of products that doesn't change depending on which locale you are using. It is only after clicking a product that we redirect the user to the English version of the support forum if they are a using an unsupported locale/product combination.

Remember that we can't add or remove products to the product selector of the AAQ without code changes.

Also, having products that are in the AAQ, but not enabled for English is a bad idea, because of the behavior above. If a product/locale combo is not available, the AAQ redirects the user to that product in English. If that isn't available in English, it creates an infinite series of redirects in some cases, or simply ignoring product not being available in other cases.

And yes, we will need to enable iOS in English after this lands in production. I was planning on doing that as a part of the deploy, since it is required.

Comment 7

[Kadir Topal [:atopal]]

(In reply to Mike Cooper [:mythmon] from comment #6)
> Also, having products that are in the AAQ, but not enabled for English is a
> bad idea, because of the behavior above. If a product/locale combo is not
> available, the AAQ redirects the user to that product in English. If that
> isn't available in English, it creates an infinite series of redirects in
> some cases, or simply ignoring product not being available in other cases.

Yeah, I tried that on allizom, that was exactly what happened.

Comment 8

[Michael Cooper [:mythmon]]

Rehan: We're planning on pushing this to -stage on Monday, so it would be nice to get this in code review some time today or tomorrow.

Comment 9

[Rehan Dalal (Inactive)]

https://github.com/mozilla/kitsune/pull/2634

Comment 10

[Michael Cooper [:mythmon]]

This has been deploy to stage for testing.

Comment 11

[Michael Cooper [:mythmon]]

Deployed to production