1152838 - BaseRect::InflateToMultiple is wrong, and we're not using it and instead inflating everything by the tile size (not to snapping to tile boundaries, as intended)

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Markus Stange [:mstange]]

Heh.

Comment 1

[Markus Stange [:mstange]]

Oh, we're not inflating by the tile size, we're just not clipping the one-pixel inflation to tiles. So it's less bad than I first thought.

Comment 2

[Markus Stange [:mstange]]

> x = static_cast<T>(floor(x / aMultiple.width)) * aMultiple.width;
> y = static_cast<T>(floor(y / aMultiple.height)) * aMultiple.height;
> xMost = static_cast<T>(ceil(x / aMultiple.width)) * aMultiple.width;
> yMost = static_cast<T>(ceil(y / aMultiple.height)) * aMultiple.height;

There are two problems with this code:
 1. It's using integer division, if the rect is an nsIntRect. So floor / ceil do nothing.
 2. The snapped xMost and yMost are computed from x / y instead of from xMost / yMost.

Comment 3

[Markus Stange [:mstange]]

Attachment: MozReview Request: bz://1152838/mstange

/r/6801 - Bug 1152838 - Fix BaseRect::InflateToMultiple and move it to nsIntRect. r=mattwoodrow, r=jrmuizel
/r/6803 - Bug 1152838 - Correctly inflate valid regions to tile boundaries. r=mattwoodrow

Pull down these commits:

hg pull -r d8025ebb54d0852b19cf1bcbd0b9247283c0dd46 https://reviewboard-hg.mozilla.org/gecko/

Comment 4

[Jeff Muizelaar [:jrmuizel]]

https://reviewboard.mozilla.org/r/6801/#review5703

Ship It!

::: gfx/2d/NumericTools.h
(Diff revision 1)
> +  // to optimize.

And slower.

Comment 5

[Matt Woodrow (:mattwoodrow)]

https://reviewboard.mozilla.org/r/6801/#review5705

Ship It!

Comment 6

[Matt Woodrow (:mattwoodrow)]

https://reviewboard.mozilla.org/r/6803/#review5707

Ship It!

Comment 7

[Markus Stange [:mstange]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/304252ab0165
https://hg.mozilla.org/integration/mozilla-inbound/rev/1e271824dcca

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/304252ab0165
https://hg.mozilla.org/mozilla-central/rev/1e271824dcca

Comment 10

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1152838 - Fix BaseRect::InflateToMultiple and move it to nsIntRect. r=mattwoodrow, r=jrmuizel

Comment 11

[Markus Stange [:mstange]]

Attachment: MozReview Request: Bug 1152838 - Correctly inflate valid regions to tile boundaries. r=mattwoodrow