Closed Bug 1152852 Opened 5 years ago Closed 5 years ago
Notification sound for highlights in chats not played if chat tab is selected, even when Thunderbird is not the currently active/focused application (in background)
Windows 8.1, Thunderbird 38 20150401012718 Reported by RyanVM, reproduced by me. The notification sound for highlights in chats is not played if the chat tab is selected, even when Thunderbird is not the currently focused application, e.g. in background. Regression from bug 961666?
This is likely a regression by bug 1127802. https://hg.mozilla.org/comm-central/annotate/e2cdfef448c1/mail/components/im/modules/chatNotifications.jsm#l43 plays the sound when the chat tab is not the active tab.
Assignee: nobody → archaeopteryx
Status: NEW → ASSIGNED
Attachment #8590475 - Flags: review?(clokep)
Attachment #8590475 - Flags: review?(clokep) → review+
Unfortunately this is in TB 38. Maybe we should uplift?
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
5 years ago
Comment on attachment 8590475 [details] [diff] [review] patch, v1 [Approval Request Comment] Regression caused by (bug #): bug 961666 User impact if declined: Chat highlights (somebody else typo one's name) won't get cause a sound notification if Thunderbird isn't the focused application but the Chat tab is the active tab. Testing completed (on c-c, etc.): Tested locally Risk to taking this patch (and alternatives if risky): low, only touches the code responsible for the sound notification
5 years ago
You need to log in before you can comment on or make changes to this bug.