1152948 - [Gallery][Edit] After editing a picture in gallery, a preview of the most recent picture taken in the gallery will appear

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Description:
(Expand upon the Summary - but not a copy of the Summary!)


Repro Steps:
1) Update a Flame to 20150409010203
2) Open Gallery app
3) Select any picture> Go into edit mode
4) Edit the picture in any way (contrast, auto enhance, crop, filter)> Save the picture


Actual:
Instead of being taken to a preview of the photo that was just edited, the photo that appears last in gallery will be shown.


Expected:
The user is taken to a preview of the photo that was just edited.


Notes: This bug seems to be related to the time of the device. Once this bug begins to happen it will appear 100% of the time, but i have found that if I do not get it I changed the time of the device, and then took a picture, then changed it back to detect time auto matically and tried to repro this bug and it would occur

Environmental Variables:
Device: Flame 3.0 (319mb)(Kitkat)(Full Flash)
Build ID: 20150409010203
Gaia: 5dfd0460eb6e616205154b0d219aa5123bf1abb3
Gecko: 8f57f60ee58a
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0


Repro frequency: 16/20
See attached: Logact, Video -

Comment 1

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Link to the video - https://youtu.be/6pypRLBA5Jo

This issue does NOT occur on Flame 2.2

The user is taken to a preview of the photo that was just edited.

Environmental Variables:
Device: Flame 2.2 (319mb)(Kitkat)(Full Flash)
Build ID: 20150409002503
Gaia: ea735c21bfb0d78333213ff0376fce1eac89ead6
Gecko: 0efd5cdbe224
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Derek Harris [:DerekH] - Dont need info. Last day 6/5/15]

Attachment: Gallery Logcat

Comment 3

[Peter Bylenga [:PBylenga]]

[Blocking Requested - why for this release]:
Functional regression of a core feature.

Requesting a window.

Comment 4

[Yeojin Chung [:YeojinC]]

This issue DOES reproduce on Flame 2.2

Result: The last taken photo is displayed after editing is done.

Environmental Variables:
Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150410002502
Gaia: df0e04acad7c8c993f6ffe07b0ccb0ec20ee50bb
Gecko: 091b1cc1240b
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

------------------------------------------
This issue does NOT reproduce on Flame 2.1.

Result: After editing, the main Gallery page is displayed.

Environmental Variables:
Device: Flame 2.1 (KK, 319mb, full flash)
Build ID: 20150410001204
Gaia: bbe983b4e8bebfec26b3726b79568a22d667223c
Gecko: 81a3aad1e6d7
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

========================================
b2g-inbound Regression Window:

Last Working Environmental Variables:
Device: Flame 2.2
BuildID: 20141023093315
Gaia: f46d56d812480bff7f3b35e8cacbedfa4d49edc5
Gecko: 9781037ac408
Version: 36.0a1 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

First Broken Environmental Variables:
Device: Flame 2.2
BuildID: 20141023095315
Gaia: d3fbba6bc6f83775e0594cb4effad1dc4d406402
Gecko: 4fb8075dc0d4
Version: 36.0a1 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Last Working Gaia First Broken Gecko: Issue does NOT reproduce 
Gaia: f46d56d812480bff7f3b35e8cacbedfa4d49edc5
Gecko: 4fb8075dc0d4

First Broken Gaia Last Working Gecko: Issue DOES reproduce
Gaia: d3fbba6bc6f83775e0594cb4effad1dc4d406402
Gecko: 9781037ac408

https://github.com/mozilla-b2g/gaia/compare/f46d56d812480bff7f3b35e8cacbedfa4d49edc5...d3fbba6bc6f83775e0594cb4effad1dc4d406402

Caused by bug 1042319

Comment 5

[KTucker [:KTucker][Inactive 3/4/2016]]

Punam, can you take a look at this please? This looks to have been caused by the work done for bug 1042319.

Comment 6

[Punam Dahiya [:pdahiya]]

(In reply to KTucker [:KTucker] from comment #5)
> Punam, can you take a look at this please? This looks to have been caused by
> the work done for bug 1042319.

Edited copy in gallery is saved with most recent date and time on the device and should show up first in thumbnail list.  Thats why this bug doesn't show up when a device is flashed with production build with current time.

If after flashing phone with older builds, there are photos that gallery app finds were taken in the future, then those will show up first.  Taking bug to discuss how to best resolve this issue.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] punamdahiya:Bug1152948 > mozilla-b2g:master

Comment 8

[Punam Dahiya [:pdahiya]]

Comment on attachment 8591813 [details] [review]
[gaia] punamdahiya:Bug1152948 > mozilla-b2g:master

Hi David
Please review attached PR that displays the latest saved edited image in fullscreen view  by using insert position. 

Assumption that saved edited image will be latest and at 0 index fails when gallery app finds existing images taken in future (#comment 0) causing them to show first.
Thanks

Comment 9

[David Flanagan [:djf]]

Comment on attachment 8591813 [details] [review]
[gaia] punamdahiya:Bug1152948 > mozilla-b2g:master

This is a nice, simple fix. Thanks, Punam.

Comment 10

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#YTR--iveSjS2eVw3vRiNNw

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 11

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/64413ac4b45981bf15dc9afdbbb8101fa6bba7a8

Comment 12

[sunny]

Attachment: verified_v3.0.mp4

This bug has been verified as pass on latest Nightly Flame v3.0 and Nexus5 v3.0,by the STR of Comment 0. 

Actual results:  The edited photo is displayed after editing is done.
See attachment: verified_v3.0.mp4
Reproduce rate: 0/6


Device: Flame 3.0 build(Pass)
Build ID               20150603160203
Gaia Revision          45dc6306cf502a4f00ae9f8bd8293a8a3a37c07b
Gaia Date              2015-06-03 17:32:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0920f2325a6d
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150603.192042
Firmware Date          Wed Jun  3 19:20:53 EDT 2015
Bootloader             L1TC000118D0


Device: Nexus5 3.0 build(Pass)
Build ID               20150603160203
Gaia Revision          45dc6306cf502a4f00ae9f8bd8293a8a3a37c07b
Gaia Date              2015-06-03 17:32:50
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0920f2325a6d
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150603.193140
Firmware Date          Wed Jun  3 19:31:59 EDT 2015
Bootloader             HHZ12f