1152969 - [Homescreen] The 'done' option becomes grayed-out and unelectable when erasing the entire name for an icon

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Joshua Mitchell (Inactive)]

Description:
 The done command is not usable when the icon name is blank. Users might want just icons without a name for their added homescreen apps. 
 If you select <enter> on the keyboard you can exit the edit mode with the blank name so there is inconsistency between the <enter> function and selecting 'done'


Repro Steps:
1) Update a Flame to 20150409010203
2) Add an icon to the homescreen
3) Enter edit mode and select the icon
4) Erase the name


Actual:
The 'done' selection is not usable


Expected:
The 'done' selection should still be selectable. 


Notes:

Environmental Variables:
Device: Flame 3.0 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150409010203
Gaia: 5dfd0460eb6e616205154b0d219aa5123bf1abb3
Gecko: 8f57f60ee58a
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0


Repro frequency: 7/7
See attached: logcat, video: http://youtu.be/2QpkjgJJmJI

Comment 1

[Joshua Mitchell (Inactive)]

This issue also reproduces in Flame KK 2.2, 2.1 and 2.0

Device: Flame 2.2 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150408002503
Gaia: ea735c21bfb0d78333213ff0376fce1eac89ead6
Gecko: 43041c78052b
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Device: Flame 2.1 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150408001204
Gaia: 87e55a7ec688138812181747f690fd188d2a0668
Gecko: 23214f805a5c
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 34.0 (2.1)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0


Device: Flame 2.0 (KK - Nightly - Full Flash - 319mem)
Build ID: 20150408000204
Gaia: 84898cadf28b1a1fcd03b726cff658de470282f0
Gecko: a782e16d271f
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 32.0 (2.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:32.0) Gecko/32.0 Firefox/32.0

Comment 2

[Joshua Mitchell (Inactive)]

Attachment: logcat_20150409_1353.txt

Comment 3

[Peter Bylenga [:PBylenga]]

NI on UX.  We have inconsistent flows, clearing the field doesn't allow you to create a bookmark/icon without a name, but entering into the text field does.  If we should allow users to choose to not name a bookmark/icon then cancel shouldn't grey out Done.  If not, then entering the text field shouldn't enable the done button.

Comment 4

[Stephany Wilkes]

Flagging Jacqueline.

Comment 5

[Hermes Cheng (inactive after July 27, 2015)]

This is definitely a bug. NI Homescreen developer.

Comment 6

[Jacqueline Savory [:jsavory] UX]

I believe the greyed out 'done' button has the correct behaviour, the user should not be able to save the title without any characters. 

Tapping the enter button should not allow the user to save if the input field has no characters - instead it should have no action when pressed. If the input field does have characters inside, tapping enter will save the title as it currently does.

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1152969-can-save-empty-bookmark-name > mozilla-b2g:master

Comment 8

[Chris Lord [:cwiiis]]

Comment on attachment 8596587 [details] [review]
[gaia] Cwiiis:bug1152969-can-save-empty-bookmark-name > mozilla-b2g:master

Fix issue and add unit test for it.

Comment 9

[Kevin Grandon :kgrandon]

Comment on attachment 8596587 [details] [review]
[gaia] Cwiiis:bug1152969-can-save-empty-bookmark-name > mozilla-b2g:master

lgtm, thanks!

Comment 10

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/84de27da21e4cf59b72a716183cf027e6e065866

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Backed out for Gaia unit test failures.
Master: https://github.com/mozilla-b2g/gaia/commit/54739ed8dedda522b21311206f5c246dc7b7ed7a

https://treeherder.mozilla.org/logviewer.html#?job_id=1787038&repo=b2g-inbound

Comment 12

[GitHub Autolander Bot]

Attachment: [gaia] Cwiiis:bug1152969-can-save-empty-bookmark-name > mozilla-b2g:master

Comment 13

[Chris Lord [:cwiiis]]

Comment on attachment 8598091 [details] [review]
[gaia] Cwiiis:bug1152969-can-save-empty-bookmark-name > mozilla-b2g:master

Carrying r=kgrandon.

Practically no change - for some reason, actually submitting the form was causing the test to hang, so just call the submit handler directly. This test passed on my initial push, I wonder if this is indicative of some other bug...

Comment 14

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/5fd082cb265885248974fbb4ff70239901a6427e

Comment 15

[Shally Li（leave from Mozilla）]

This bug has been verified as pass on latest Nightly build of Flame v3.0 and Nexus 5 v3.0 by the STR in Comment 0.

Actual results: Both "Done" button and enter button are not usable when the input field has no any characters.
See attachment: verified_v3.0.mp4
Reproduce rate: 0/6


Device: Flame v3.0 build(Pass)
Build ID               20150601160204
Gaia Revision          6d477a7884273886605049b20f60af5c1583a150
Gaia Date              2015-06-01 16:41:42
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/56241c1f8a3b
Gecko Version          41.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150601.193935
Firmware Date          Mon Jun  1 19:39:44 EDT 2015
Bootloader             L1TC000118D0

Device: Nexus 5 v3.0 build(Pass)
Build ID               20150601075320
Gaia Revision          85e6fcef45c0cb2c017739df42b68b96cf5bb9c3
Gaia Date              2015-06-01 06:40:19
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/666b584fb521
Gecko Version          41.0a1
Device Name            hammerhead
Firmware(Release)      5.1
Firmware(Incremental)  eng.cltbld.20150601.112653
Firmware Date          Mon Jun  1 11:27:09 EDT 2015
Bootloader             HHZ12f

----------------------------------------------------------
Leaving "verifyme" for v2.0&2.1&2.2 uplift & verification.

Comment 16

[Shally Li（leave from Mozilla）]

Attachment: verified_v3.0.mp4

Comment 17

[Duane Dixon [:ddixon]]

Removing verifyme tag based on comment 15 findings.

Comment 18

[Duane Dixon [:ddixon]]

Also, confirming the findings in comment 15. 

Actual Results: The user cannot add an icon to the homescreen while there is no text in the name field and hitting enter on the keyboard. 

Latest Flame Nightly master build: 

Device: Flame 2.5
BuildID: 20150731030207
Gaia: 8502d07cd7e68da79303471acf64eea48b3dce24
Gecko: ca53d4297f02
Gonk: 41d3e221039d1c4486fc13ff26793a7a39226423
Version: 42.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0