Closed
Bug 1153027
Opened 10 years ago
Closed 10 years ago
Bugzilla->feature incorrectly checks Perl modules
Categories
(Bugzilla :: Bugzilla-General, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 5.0
People
(Reporter: LpSolit, Assigned: LpSolit)
Details
Attachments
(1 file)
|
1.17 KB,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
I was wondering why REST was crashing pretty badly today, and the reason was that the new REST code requires Moo 2.0 instead of 1.3 (required by Email::Sender). rest.cgi was supposed to catch that thanks to:
if (!Bugzilla->feature('rest')) {
ThrowUserError('feature_disabled', { feature => 'rest' });
}
but Bugzilla->feature only makes sure that all the required modules are installed, not that they match the minumum version required. That's a bug! The patch fixes this.
Attachment #8590546 -
Flags: review?(dylan)
|
Assignee | |
Updated•10 years ago
|
Attachment #8590546 -
Flags: review?(dylan) → review?(dkl)
|
||
Comment 1•10 years ago
|
||
Comment on attachment 8590546 [details] [diff] [review]
patch, v1
Review of attachment 8590546 [details] [diff] [review]:
-----------------------------------------------------------------
r=dkl
Attachment #8590546 -
Flags: review?(dkl) → review+
|
|
||
Updated•10 years ago
|
Flags: approval?
Flags: approval?
Flags: approval5.0+
Flags: approval+
Target Milestone: --- → Bugzilla 5.0
|
|
Assignee | |
Comment 2•10 years ago
|
||
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
464dad0..d82782d master -> master
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
d725139..4cbac02 5.0 -> 5.0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•