Closed
Bug 1153067
Opened 10 years ago
Closed 10 years ago
[Stingray] [Component] Use :after element as a mask to simulate dialog opening animation
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: suchiu, Assigned: suchiu)
Details
Attachments
(1 file)
Currently in smart-dialog, opening and closing animations are implemented by scaling smart-dialog element, which could have side effect of scaling children and content. Using :after element as a mask is a better option.
|
Assignee | |
Comment 1•10 years ago
|
||
1. smart-dialog element remains fixed position with full-screen size.
2. Use :after element as a black mask to implement opening and closing animation.
3. Able to open dialog again when closing, and vice versa.
4. Use visibility:hidden instead of display:none in opened and closed state because display:none will disable CSS transition.
5. Eliminate force reflow hack when closing.
Attachment #8590608 -
Flags: review?(im)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8590608 [details] [review]
Pull Request
looks good to me. thanks.
Attachment #8590608 -
Flags: review?(im) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Commit: https://github.com/smart-components/smart-dialog/commit/b9a6a742b8a7d9fec8f0328ce6d22d11c684f6ea
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•