Closed Bug 1153069 Opened 9 years ago Closed 9 years ago

Multilocale env vars break ./bin/gaia-test

Categories

(Firefox OS Graveyard :: Gaia::Build, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Build
Platform:
All
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: drs, Assigned: julienw)

Details

Attachments

(1 file)

[gaia] julienw:1153069-fix-multilocale-debug-mode > mozilla-b2g:master
46 bytes, text/x-github-pull-request
rickychien
: review+
Details | Review 
I'm not sure whether this should be filed under Gaia::TestAgent or Gaia::L10n, so I chose the former, since that's what's actually broken.

I added the following env vars to my |~/.bash_profile| file, so that they'd be sourced at all times and I'd have every locale accessible in my builds:

```bash
export LOCALE_BASEDIR=/Volumes/firefoxos/gaia/locales
export LOCALES_FILE=/Volumes/firefoxos/gaia/locales/languages_dev.json
```

These paths are both valid and correct.

The test-agent runner starts correctly inside Nightly, and displays the list of tests like usual. However, when I select one or more tests and hit "Execute", nothing happens. If I instead `touch` a test file, the following is printed, but the tests aren't actually run:

Running tests:  [ '/communications/dialer/test/unit/call_log_test.js' ]

I notice that I get the following error on startup when these env vars are set, but I don't get it when they're not:

/Applications/Xcode.app/Contents/Developer/usr/bin/make modules.tar
214794248721479424871428636666741	addons.xpi	WARN	Exception running bootstrap method startup on httpd@gaiamobile.org: TypeError: Illegal constructor (resource://gre/modules/commonjs/toolkit/loader.js -> file:///Volumes/firefoxos/gaia/build/multilocale.js:17) JS Stack trace: L10nManager@multilocale.js:17:1 < startupHttpd@bootstrap.js:103:21 < startup@bootstrap.js:510:3 < XPI_callBootstrapMethod@XPIProvider.jsm:4451:9 < XPI_startup@XPIProvider.jsm:2168:13 < callProvider@AddonManager.jsm:208:12 < _startProvider@AddonManager.jsm:670:5 < AMI_startup@AddonManager.jsm:838:9 < AMP_startup@AddonManager.jsm:2496:5 < AMC_observe@addonManager.js:55:7
I looked at the history of both bootstrap.js and multilocale.js and some things are not clear to me. For example I don't understand how multilocale.js could work at all after [1] (bug 968666): 3 arguments, but the check checks whether there are 4 arguments.

[1] https://github.com/mozilla-b2g/gaia/commit/a29259475596c3080199aa54985c177d4f21199c

A patch is coming.
Assignee: nobody → felash
Attachment #8590650 - Flags: review?(ricky060709)
Comment on attachment 8590650 [details] [review]
[gaia] julienw:1153069-fix-multilocale-debug-mode > mozilla-b2g:master

r+ LGTM.
Attachment #8590650 - Flags: review?(ricky060709) → review+
Keywords: checkin-needed
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
Component: Gaia::TestAgent → Gaia::Build
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: