Status

()

--
enhancement
4 years ago
3 days ago

People

(Reporter: glob, Unassigned)

Tracking

(Blocks: 1 bug)

Production

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
bugzillajs has a nice feature that shows github logs inline when a comment contains a commit url.

we should steal that :)
(Reporter)

Updated

3 years ago
Assignee: nobody → glob
(Reporter)

Comment 1

3 years ago
Created attachment 8630336 [details] [diff] [review]
1153083_1.patch
Attachment #8630336 - Flags: review?(dkl)
Comment on attachment 8630336 [details] [diff] [review]
1153083_1.patch

Review of attachment 8630336 [details] [diff] [review]:
-----------------------------------------------------------------

Overall looks great. Couple of comments...

1) If the same github link shows up more than once in the same comment, you get multiple tables showing the same data. Need to mark a unique API url as done.
2) The timestamp should be converted from UTC to relative time.
3) Maybe also include the commit id in the header for each github block. Otherwise if multiple links are embedded in the comment text, I cannot tell which block matches which link.

dkl
Attachment #8630336 - Flags: review?(dkl) → review-
(Reporter)

Comment 3

3 years ago
while working on this i hit github's unauthenticated rate limit of 60 requests per ip per hour.
that's painfully low, and throws a large spanner into the works here.

looks like the way forward here is for github api request to be made against a bmo endpoint, which leans on memcache to ensure we make conditional and authenticated requests to github.  if we still hit limits then we'll probably have to reach out to github to get our limit raised.
(Reporter)

Updated

3 years ago
Assignee: glob → nobody

Updated

2 years ago
Severity: normal → enhancement

Updated

12 days ago
Blocks: 1496895
You need to log in before you can comment on or make changes to this bug.