Closed
Bug 1153083
Opened 9 years ago
Closed 5 years ago
show github logs inline
Categories
(bugzilla.mozilla.org :: User Interface, enhancement)
Tracking
()
RESOLVED
WONTFIX
People
(Reporter: glob, Unassigned)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
11.03 KB,
patch
|
dkl
:
review-
|
Details | Diff | Splinter Review |
bugzillajs has a nice feature that shows github logs inline when a comment contains a commit url. we should steal that :)
Attachment #8630336 -
Flags: review?(dkl)
Comment 2•9 years ago
|
||
Comment on attachment 8630336 [details] [diff] [review] 1153083_1.patch Review of attachment 8630336 [details] [diff] [review]: ----------------------------------------------------------------- Overall looks great. Couple of comments... 1) If the same github link shows up more than once in the same comment, you get multiple tables showing the same data. Need to mark a unique API url as done. 2) The timestamp should be converted from UTC to relative time. 3) Maybe also include the commit id in the header for each github block. Otherwise if multiple links are embedded in the comment text, I cannot tell which block matches which link. dkl
Attachment #8630336 -
Flags: review?(dkl) → review-
while working on this i hit github's unauthenticated rate limit of 60 requests per ip per hour. that's painfully low, and throws a large spanner into the works here. looks like the way forward here is for github api request to be made against a bmo endpoint, which leans on memcache to ensure we make conditional and authenticated requests to github. if we still hit limits then we'll probably have to reach out to github to get our limit raised.
Updated•5 years ago
|
Component: User Interface: Modal → User Interface
This still relevant?
Flags: needinfo?(glob)
No - it was a nice feature however, in order for it to work would require infra to proxy all GitHub API requests.
Coupled with no one raising this as a concern for some time now means we can just close this out.
Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(glob)
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•