Closed Bug 1153101 Opened 9 years ago Closed 9 years ago

update EditComments to work with the modal UI

Categories

(bugzilla.mozilla.org :: Extensions, defect)

Production
x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: glob, Assigned: glob)

References

Details

Attachments

(1 file)

- add hooks for edit-comments extension, as a comment-action
- update edit-comments to support both button styles
Priority: -- → P1
Priority: P1 → --
Assignee: nobody → glob
Attached patch 1153101_1.patchSplinter Review
i figured it was simpler to support just bug_modal instead of both (this is an admin-only function and the bmo team all use bug_modal).

- add hook to bug_modal for comment actions
- adds button and link to comment history where required
- yui --> jquery
- simplifies comment history page by removing comment collapsing (most comment have very few edits, and this made it much easier to convert to jquery)
Attachment #8672946 - Flags: review?(dylan)
Comment on attachment 8672946 [details] [diff] [review]
1153101_1.patch

Review of attachment 8672946 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan
Attachment #8672946 - Flags: review?(dylan) → review+
To ssh://gitolite3@git.mozilla.org/webtools/bmo/bugzilla.git
   5265c09..2e2981d  master -> master
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: User Interface: Modal → Extensions: EditComments
Summary: add hooks for edit-comments extension → update EditComments to work with the modal UI
Component: Extensions: EditComments → Extensions
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: