Closed Bug 1153107 Opened 9 years ago Closed 9 years ago

[Stingray]JavaScript error: card_manager.js, line 71: TypeError: folder.cardsInFolder is undefined

Categories

(Firefox OS Graveyard :: Gaia::TV::Home, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::Home
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: dwi2, Assigned: dwi2)

References

Details

Attachments

(1 file)

[gaia] dwi2:bug1153107 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
rexboy
: review+
Details | Review 
There is an error when card manager tries to write folder back to data store.

JavaScript error: app://smart-home.gaiamobile.org/shared/js/smart-screen/card_manager.js?time=1428648169246, line 71: TypeError: folder.cardsInFolder is undefined

This is because we change 'cardsInFolder' in folder.js to '_cardsInFolder' as a private property. And all other module besides folder.js should use getCardList() instead of calling '_cardsInFolder' directly.
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Comment on attachment 8590696 [details] [review]
[gaia] dwi2:bug1153107 > mozilla-b2g:master

Hi Rex,

I found this error after bug 1150419 landing. Please help to review the patch. Thanks
Attachment #8590696 - Flags: review?(rexboy)
Comment on attachment 8590696 [details] [review]
[gaia] dwi2:bug1153107 > mozilla-b2g:master

Looks good to me.
Attachment #8590696 - Flags: review?(rexboy) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [partner-cherry-pick]
Whiteboard: [partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: