1153136 - Add keyboard layout for Frisian (fy)

Status: RESOLVED DUPLICATE of bug 1160883

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Wim]

Attachment: fy.js

In preparation of adding a dictionary, I already would like to add the Frisian keyboard layout.

Comment 1

[Wim]

Frisian wordslist is requested in https://bugzilla.mozilla.org/show_bug.cgi?id=1160883

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Wim, 


Are you interested in making this a Gaia patch?
You could follow the guideline here and set the review flag to me,
https://github.com/mozilla-b2g/gaia/blob/master/CONTRIBUTING.md

Besides, you could try to modify the keyboard build integration as specified here,
https://github.com/mozilla-b2g/gaia/tree/master/apps/keyboard

If this is not in your area, please feel free to let me and I'll take over from here.
Thanks.

Comment 3

[Wim]

Hi Rudy Lu,
Although I could be able to work my way through the system of Gaia in Github, I'd prefer if you took it over, it probably will be much faster.
If you need any specific information, please don't hesitate to ask, I'd be more than happy to help.

Comment 4

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

I'll take this.
Thanks for the info.

Comment 5

[Wim]

I am a bit unsure about the language code.
For Mozilla we always use fy-NL instad of fy, but I don't know if the code in fy.js has any unexpected effects when used in Firefox OS.
The app I made for testing didn't localize to Frisian for the settings part, so I guess I need to change languagecode there.
Still investigating...

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/b6c5fda821dce99babf8b9d5799a95eb4aeca64a

Comment 7

[Delphine Lebédel [:delphine - use need info]]

Josh: can we get this approved to land on 2.2 please? As usual, it's minimal risk, this language has autocorrection already and is 100% complete + tested. So would be great for users to get that on 2.2 :)
thanks!

Comment 8

[Josh Cheng [:josh]]

Hi Rudy,
Please help to raise 2.2 uplift request. Thanks!

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Rudy's gone. Is there someone else who can do the request?

Comment 11

[Théo Chevalier [:tchevalier]]

Looks like everything has landed on master and 2.2 (dictionary and layout) in bug 1160883. Frysk layout on 2.2: https://github.com/mozilla-b2g/gaia/blob/v2.2/apps/keyboard/js/layouts/fy.js 

Marking as dupe to reflect that.

Comment 12

[Théo Chevalier [:tchevalier]]

However the fy layout has not been set by default for fy-NL locale: https://github.com/mozilla-b2g/gaia/blob/master/build/config/keyboard-layouts.json#L86

I'll do it in Bug 1183933.