115318 - nsHTMLURIRefObject::GetNextURI returns wrong value when finished

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Akkana Peck]

The JS link checking code expects nsHTMLURIRefObject::GetNextURI to return
NS_ERROR_NOT_AVAILABLE when it has no more links, but that code apparently
didn't get checked in along with other fixes.  The sympton is this when running
Debug->Check Links:

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE)
[nsIURIRefObject.GetNextURI]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)" 
location: "JS frame :: chrome://editor/content/ComposerCommands.js :: anonymous
:: line 1231"  data: no]
************************************************************

Patch coming, looking for review/sr.

Comment 1

[Akkana Peck]

Attachment: Patch: return the right value, and clean up some other error-checking code

Comment 2

[Akkana Peck]

These changes went in along with the new dialog.

Comment 3

[Charles Manske]

verified