1153186 - Split Bugzilla/ElasticSearch submission tasks to separate queues & clean up post TBPL-EOL

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect, P2)

Description

[Ed Morley [:emorley]]

Post bug 1069502 / bug 1069560 a number of the comments, function and file names are out of date. In addition, we should make the task names clearer & split the tasks into separate queues, for both improved visibility, and also the ability to pause just OrangeFactor submission (ie let a queue build up), which is necessary for bug 1142538.

Comment 1

[Ed Morley [:emorley]]

Attachment: Classification mirroring cleanup + queue split

Comment 2

[Cameron Dawson [:camd]]

Comment on attachment 8590812 [details] [review]
Classification mirroring cleanup + queue split

This lgtm.  :)

Comment 3

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-service

https://github.com/mozilla/treeherder-service/commit/8c836a93fbbb9336362dc31c6f4c29e6ac5850f2
Bug 1153186 - Use "classification_mirroring" in filenames instead of "tbpl"

These tasks no longer submit to TBPL, but to Bugzilla/Elasticsearch
directly, so this is a more appropriate name.

https://github.com/mozilla/treeherder-service/commit/a3af89f2b82eba51c5760aee559680de30ce6721
Bug 1153186 - Rename OrangeFactorRequest BugzillaBugRequest

We're submitting to Elasticsearch (used by OrangeFactor), not directly
to OrangeFactor, so "Elasticsearch" is more appropriate. The use of
"Bug" in the name makes it sound like we're submitting a bug, which
we're not, we're submitting a bug comment (or ES doc) which contains a
number of different fields, in response to a classification entry made a
sheriff iff the classification included a bug number, which is slightly
different, and too nuanced to include in the name.

As such whilst not perfect, I think this is slightly clearer:
s/OrangeFactorRequest/ElasticsearchDocRequest/
and
s/BugzillaBugRequest/BugzillaCommentRequest/

https://github.com/mozilla/treeherder-service/commit/0c12b0dd838d79acd3cb6bde2088207eb4de5544
Bug 1153186 - Remove tbpl from test names

https://github.com/mozilla/treeherder-service/commit/c8daf2d2d7c1cb64aa5fd9c55955e030575142dd
Bug 1153186 - Clean up Bugzilla/Elasticsearch/TBPL related comments

https://github.com/mozilla/treeherder-service/commit/10b6e1b54cae3ccdfb03dcb4d5b4d343cf8a28bd
Bug 1153186 - Rename the submit_star_comment & submit_bug_comment tasks

s/submit_star_comment/submit_elasticsearch_doc/
s/submit-star-comment/submit-elasticsearch-doc/
s/submit_bug_comment/submit_bugzilla_comment/
s/submit-bug-comment/submit-bugzilla-comment/

https://github.com/mozilla/treeherder-service/commit/87f6605de1909fbcf9c79f55590c07472b763e2f
Bug 1153186 - Split up the high_priority task queue

...into 'classification_mirroring' and 'publish_to_pulse'. This gives
greater visibility into the relative queue sizes of each, allows us to
move one of them to another node, plus means we can pause consumption of
the classification_mirroring task for when the Elasticsearch indicies
are migrated in bug 1142538.

https://github.com/mozilla/treeherder-service/commit/bddfcfed70e1f34644f7cc4a7495914d0fd42a59
Bug 1153186 - s/TBPL_BUGS_TRANSFER_ENABLED/MIRROR_CLASSIFICATIONS/